Skip to content

Add timestamp logicaltype - #36705

Merged
damccorm merged 2 commits into
apache:masterfrom
claudevdm:timestam-logicaltype
Nov 5, 2025
Merged

Add timestamp logicaltype#36705
damccorm merged 2 commits into
apache:masterfrom
claudevdm:timestam-logicaltype

Conversation

@claudevdm

@claudevdmclaudevdm commented Nov 2, 2025

Copy link
Copy Markdown
Collaborator

Add timestamp logical type as described in https://s.apache.org/beam-timestamp-strategy


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@claudevdmclaudevdm changed the title Timestam logicaltypeAdd timestamo logicaltypeNov 5, 2025
@claudevdm
claudevdm marked this pull request as ready for review November 5, 2025 14:42
@claudevdm

Copy link
Copy Markdown
CollaboratorAuthor

R: @ahmedabu98
R: @Abacn
R: @damccorm

@claudevdmclaudevdm changed the title Add timestamo logicaltypeAdd timestamp logicaltypeNov 5, 2025
@github-actions

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@claudevdm

Copy link
Copy Markdown
CollaboratorAuthor

/gemini review

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Timestamp logical type, which is a great addition for handling timestamps with configurable precision in Beam schemas. The implementation is solid and the accompanying tests are very thorough, covering a wide range of positive, negative, and edge cases. I have a couple of suggestions to improve the implementation's readability, maintainability, and performance, mainly around avoiding magic numbers for field access and replacing Math.pow with a more efficient alternative.

@damccormdamccorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm
damccorm merged commit bf19899 into apache:masterNov 5, 2025
22 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@claudevdm@damccorm