Skip to content

Remove dead code.#36943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abacn merged 2 commits into from
Dec 1, 2025
Merged

Remove dead code. #36943

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
943e815
Remove dead code.
claudevdm Nov 30, 2025
28bd9aa
Lint.
claudevdm Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .../java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiDynamicDestinationsGenericRecord.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,6 @@
import com.google.protobuf.Message;
import org.apache.avro.Schema;
import org.apache.avro.generic.GenericRecord;
import org.apache.beam.sdk.extensions.avro.schemas.utils.AvroUtils;
import org.apache.beam.sdk.io.gcp.bigquery.BigQueryServices.DatasetService;
import org.apache.beam.sdk.transforms.SerializableFunction;
import org.checkerframework.checker.nullness.qual.NonNull;
Expand DownExpand Up@@ -63,13 +62,11 @@ class GenericRecordConverter implements MessageConverter<T> {

final com.google.cloud.bigquery.storage.v1.TableSchema protoTableSchema;
final Schema avroSchema;
final TableSchema bqTableSchema;
final Descriptor descriptor;
final @javax.annotation.Nullable Descriptor cdcDescriptor;

GenericRecordConverter(DestinationT destination) throws Exception {
avroSchema = schemaFactory.apply(getSchema(destination));
bqTableSchema = BigQueryUtils.toTableSchema(AvroUtils.toBeamSchema(avroSchema));
protoTableSchema =
AvroGenericRecordToStorageApiProto.protoTableSchemaFromAvroSchema(avroSchema);
descriptor =
Expand DownExpand Up@@ -112,7 +109,7 @@ public TableRow toFailsafeTableRow(T element) {
return formatRecordOnFailureFunction.apply(null, element);
} else {
return BigQueryUtils.convertGenericRecordToTableRow(
toGenericRecord.apply(new AvroWriteRequest<>(element, avroSchema)), bqTableSchema);
toGenericRecord.apply(new AvroWriteRequest<>(element, avroSchema)));
}
}

Expand Down
Loading