Skip to content

Compare Schema argument type in a null-friendly way - #38092

Merged
ahmedabu98 merged 1 commit into
apache:masterfrom
ahmedabu98:fix_sql_postocmmit
Apr 7, 2026
Merged

Compare Schema argument type in a null-friendly way#38092
ahmedabu98 merged 1 commit into
apache:masterfrom
ahmedabu98:fix_sql_postocmmit

Conversation

@ahmedabu98

Copy link
Copy Markdown
Contributor

Fixes SQL Postcommits

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the robustness of the Schema comparison logic in the Java SDK by ensuring that logical type arguments are compared in a null-friendly manner. Additionally, it updates a configuration file to trigger the necessary SQL PostCommit test suite.

Highlights

  • Null-safe comparison: Updated the Schema field type comparison logic to use Objects.equals for the logical type argument, preventing potential NullPointerExceptions.
  • CI Trigger: Incremented the modification counter in the SQL PostCommit trigger file to ensure the test suite runs.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Abacn

Abacn commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

apparently triggered runs are interfering with each other. Opened #38093 for fix.

@github-actions

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@ahmedabu98
ahmedabu98 merged commit 8e40d44 into apache:masterApr 7, 2026
22 of 24 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ahmedabu98@Abacn