Uh oh!
There was an error while loading. Please reload this page.
Replace non-PEP 585 types in watch.py - #39527
Conversation
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Assigning reviewers: R: @shunping for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Abacn
commented
Jul 28, 2026
Are we going to have lint check for this kind of issues? |
jrmccluskey
commented
Jul 28, 2026
It should already be doing so, I'm not entirely sure how watch.py dodged this (and ruff picked it up locally, so I need to check what the blind spot is.) I'm separately updating the ruff version in #39531, I'll see if I need to make any configuration updates there |
Uh oh!
There was an error while loading. Please reload this page.
Resolves the watch.py conflict with fc0d989, keeping the PEP 585 spellings from apache#39527.
typing.Tupleandtyping.Iterableusages in watch.py are incorrect, this updates to the modern hint format.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.