Uh oh!
There was an error while loading. Please reload this page.
JmsIO yaml - #39818
Conversation
| config: | ||
| gradle_target: 'sdks:java:extensions:schemaio-expansion-service:shadowJar' | ||
| # JMS |
There was a problem hiding this comment.
JmsIO uses user provided client. Beam's messaging-expansion-service shades activeMQ provider, but we should support user provided client. In xlang_jsmio_it_test it used IBM MQ as an example. Consider support 'ReadFromIbmMQ' and 'WriteToIbmMQ' here, by configuring classpath=[ 'com.ibm.mq:com.ibm.mq.allclient:9.3.0.25', 'org.json:json:20251224']
I'm not sure if Beam YAML's config: supports pluggable classpath, it should do.
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
| dependsOn ":sdks:java:io:expansion-service:build" | ||
| dependsOn ":sdks:java:io:google-cloud-platform:expansion-service:build" | ||
| dependsOn ":sdks:java:io:debezium:expansion-service:shadowJar" | ||
| dependsOn ":sdks:java:io:messaging-expansion-service:shadowJar" |
There was a problem hiding this comment.
Consider move this to postCommitYamlIntegrationTests. The test only need to be exercised on postsubmit time. The PreCommit becomes heavier as we are adding more expansion services (and test container). Same apply to Snowflake / Kenesis / debezium
Assigning reviewers: R: @damccorm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Successful run:
https://github.com/apache/beam/actions/runs/32357254132
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.