Skip to content

Flink registrar - #40

Closed
ravwojdyla wants to merge 2 commits into
apache:masterfrom
ravwojdyla:flink-registrar
Closed

Flink registrar#40
ravwojdyla wants to merge 2 commits into
apache:masterfrom
ravwojdyla:flink-registrar

Conversation

@ravwojdyla

@ravwojdylaravwojdyla commented Mar 11, 2016

Copy link
Copy Markdown
Contributor

No description provided.

Rafal Wojdyla added 2 commits March 11, 2016 13:40
Rafal Wojdyla
Add FlinkRunnerRegistrar
0d1b63b
Expose Flink runner and options via AuteService. AuteService will
at compile time populate META-INF/services so that Dataflow sdk
can seamlessly pick up FlinkRunner.
Rafal Wojdyla
Bring some structure to the flink runner pom
2e1f8d3
 * separate test from compile and runtime deps
@ravwojdyla

ravwojdyla commented Mar 11, 2016

Copy link
Copy Markdown
ContributorAuthor

ping @mxm - copy from dataArtisans/flink-dataflow#22

@davorbonaci

davorbonaci commented Mar 11, 2016

Copy link
Copy Markdown
Member

Apache ICLA might be needed for us to merge. We have to clarify the contribution rules -- sorry for not being completely ready to take contributions yet.

@ravwojdyla

ravwojdyla commented Mar 11, 2016

Copy link
Copy Markdown
ContributorAuthor

@davorbonaci thanks for reaching out! is there anything I need to do?

@davorbonaci

davorbonaci commented Mar 11, 2016

Copy link
Copy Markdown
Member

We haven't yet adopted the guidelines what is specifically required. Please bear with us until early next week until we clarify this.

@mxm

mxm commented Mar 16, 2016

Copy link
Copy Markdown
Contributor

From http://www.apache.org/licenses/#clas

The ICLA is necessary for committers:

A signed ICLA is required to be on file before an individual is given commit rights to an ASF project.

Further:

The ASF desires that all contributors of ideas, code, or documentation to any Apache projects complete, sign, and submit (via fax or email) an Individual Contributor License Agreement (ICLA)

For small contributions like this, we're at a grey spot. So if in doubt, you could simply file the ICLA and submit it to secretary@apache.org. It is a one-time process which shouldn't take long.

@kennknowles

kennknowles commented Mar 17, 2016

Copy link
Copy Markdown
Member

For leisurely reading, the ICLA+PR issue is discussed in this general@incubator thread from 2015-01 and then this incubator-tinkerpop-dev thread from 2015-02. It centers on clause 5. Has there been resolution since then?

@davorbonaci

davorbonaci commented Mar 17, 2016

Copy link
Copy Markdown
Member

Exactly -- that's is exactly a part of our soon-to-be-proposed contribution guidelines, which was also discussed with @jbonofre.

So, I think this pull request can proceed with any CLAs.

@mxm, do you want to take the review & merge of this one?

@mxm

mxm commented Mar 17, 2016

Copy link
Copy Markdown
Contributor

Thanks for the input @kennknowles. I think we're pretty much on the safe side then for contributions like this one.

@davorbonaci Sure I'll take care.

mxm
mxm reviewed Mar 17, 2016
View reviewed changes
Comment threadrunners/flink/pom.xml
<artifactId>flink-test-utils_${scala.major.version}</artifactId>
<version>${flink.version}</version>
<scope>test</scope>
</dependency>

@mxmmxmMar 17, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been restructured in the meantime. I won't merge this commit.

asfgit pushed a commit that referenced this pull request Mar 21, 2016
@mxm
Thiscloses#40
c984f3a
asfgit pushed a commit that referenced this pull request Mar 23, 2016
Rafal Wojdyla@mxm
[flink] Add FlinkRunnerRegistrar
e94e7d6
Expose Flink runner and options via AuteService. AuteService will
at compile time populate META-INF/services so that Dataflow sdk
can seamlessly pick up FlinkRunner.
This closes#40.
aljoscha pushed a commit to aljoscha/beam that referenced this pull request Mar 28, 2018
@bsidhom
Merge pull requestapache#40from bsidhom/flat-namespace
b6d4021
Flatten artifact names by escaping full paths
mareksimunek pushed a commit to mareksimunek/beam that referenced this pull request May 9, 2018
@horkyada@vanekjar
apache#99Sort operator support
3d5fd30
* #! - eclipse compilation
* apache#40 - Sort operator with in-memory RSBK sorting
* apache#40 - Spark SortTranslator
* apache#40 - Flink SortTranslator
* apache#40 - RangePartitioning
* apache#40 - PR#99
dmvk pushed a commit to dmvk/beam that referenced this pull request May 15, 2018
@horkyadaDavid Moravek
apache#99Sort operator support
ccb0c34
* #! - eclipse compilation
* apache#40 - Sort operator with in-memory RSBK sorting
* apache#40 - Spark SortTranslator
* apache#40 - Flink SortTranslator
* apache#40 - RangePartitioning
* apache#40 - PR#99
tvalentyn pushed a commit to tvalentyn/beam that referenced this pull request May 15, 2018
@francesperry
Regenerate html forapache#40
27b5e76
tvalentyn pushed a commit to tvalentyn/beam that referenced this pull request May 15, 2018
@francesperry
[Beam-665] Thisclosesapache#40.
71d95e3
mareksimunek referenced this pull request in seznam/beam Jul 9, 2018
@horkyadamarek.simunek
apache#99Sort operator support
b8d9692
* #! - eclipse compilation
* #40 - Sort operator with in-memory RSBK sorting
* #40 - Spark SortTranslator
* #40 - Flink SortTranslator
* #40 - RangePartitioning
* #40 - PR#99
dmvk referenced this pull request in seznam/beam Aug 17, 2018
@horkyadaDavid Moravek
apache#99Sort operator support
b27cb9e
* #! - eclipse compilation
* #40 - Sort operator with in-memory RSBK sorting
* #40 - Spark SortTranslator
* #40 - Flink SortTranslator
* #40 - RangePartitioning
* #40 - PR#99
kennknowles pushed a commit that referenced this pull request Oct 16, 2018
@horkyadaDavid Moravek
#99Sort operator support
d58c055
* #! - eclipse compilation
* #40 - Sort operator with in-memory RSBK sorting
* #40 - Spark SortTranslator
* #40 - Flink SortTranslator
* #40 - RangePartitioning
* #40 - PR#99
robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Apr 30, 2020
@bntnam@robertwb
Updated repo with current website (apache#40)
98e11bb
hengfengli referenced this pull request in hengfengli/beam Mar 21, 2022
@zoercai
feat: allow user specified metadata instance (#40)
fd74ffc
sjvanrossum pushed a commit to sjvanrossum/beam that referenced this pull request May 22, 2023
@laysakura
Merge pull requestapache#40from laysakura/refactor/coder-trait-object
729b62c
feat: Coder made into object safe
pl04351820 pushed a commit to pl04351820/beam that referenced this pull request Dec 20, 2023
@czahedi
feat: Create CODEOWNERS (apache#40)
a0cbf40
Adding owner team
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ravwojdyla@davorbonaci@mxm@kennknowles