Uh oh!
There was an error while loading. Please reload this page.
[BEAM-374] Enable dependency-plugin and failOnWarning at global level. - #516
[BEAM-374] Enable dependency-plugin and failOnWarning at global level.#516peihe wants to merge 3 commits into
Conversation
peihe
commented
Jun 22, 2016
R: @amitsela for checking the correctness of the spark dependency. |
| <dependency> | ||
| <groupId>org.slf4j</groupId> | ||
| <artifactId>slf4j-api</artifactId> | ||
| <version>1.7.14</version> |
There was a problem hiding this comment.
version numbers should be inherited from root-level pom, I think. See grpc above, for instance.
amitsela
commented
Jun 23, 2016
Added comments, mainly relating to @dhalperi comment on inheriting versions for root level pom (and some suggestions for additional once for Spark's pom). And how does this relate to removing beam-examples dependencies ? Why do we want to remove this dependency ? I would prefer a dependency to use beam-examples in the runner's tests on duplicating them. |
peihe
commented
Jun 23, 2016
Users should be able to run beam-examples with any runners, and beam-examples will need runtime dependency to runners-spark. I cannot add that runtime dependency when runners-spark depends on beam-examples. Previously, runners-spark is pull dependency from other module, and runners-spark can be broken by dependency changes in other module (removing, changing version, and even adding). This is another benefits. |
amitsela
commented
Jun 24, 2016
Makes sense. Thanks for clarifying that! |
| @@ -861,15 +861,6 @@ | |||
| </plugin> | |||
peihe
commented
Jun 24, 2016
@dhalperi PTAL, and merge if it looks good. Thanks |
davorbonaci
commented
Jun 24, 2016
LGTM. |
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Spark dependency fix is included in this PR. This is to remove the beam-examples dependency from Spark.
failOnWarning is disabled for Flink for now.
The added dependencies in this PR come from "mvn dependency:analyze"