Uh oh!
There was an error while loading. Please reload this page.
[BEAM-378] integrate setuptools in Maven build#537
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # | ||
| # Licensed to the Apache Software Foundation (ASF) under one or more | ||
| # contributor license agreements. See the NOTICE file distributed with | ||
| # this work for additional information regarding copyright ownership. | ||
| # The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| # (the "License"); you may not use this file except in compliance with | ||
| # the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
| # This file is used from Python to sync versions | ||
| include pom.xml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,169 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- | ||
| Licensed to the Apache Software Foundation (ASF) under one or more | ||
| contributor license agreements. See the NOTICE file distributed with | ||
| this work for additional information regarding copyright ownership. | ||
| The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| (the "License"); you may not use this file except in compliance with | ||
| the License. You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| --> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
| <parent> | ||
| <groupId>org.apache.beam</groupId> | ||
| <artifactId>beam-sdks-parent</artifactId> | ||
| <version>0.3.0-incubating-SNAPSHOT</version> | ||
| <relativePath>../pom.xml</relativePath> | ||
| </parent> | ||
| <artifactId>beam-sdks-python</artifactId> | ||
| <packaging>pom</packaging> | ||
| <name>Apache Beam :: SDKs :: Python</name> | ||
| <properties> | ||
| <python.interpreter.bin>python2</python.interpreter.bin> | ||
| <python.pip.bin>pip2</python.pip.bin> | ||
| <python.build.base>${project.build.directory}/build</python.build.base> | ||
| <python.user.base>${project.build.directory}/python</python.user.base> | ||
| </properties> | ||
| <build> | ||
| <pluginManagement> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.codehaus.mojo</groupId> | ||
| <artifactId>exec-maven-plugin</artifactId> | ||
| <executions> | ||
| <execution> | ||
| <!-- trick by @aaltay to skip inheritance --> | ||
| <phase>none</phase> | ||
| </execution> | ||
| </executions> | ||
| </plugin> | ||
| </plugins> | ||
| </pluginManagement> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.codehaus.mojo</groupId> | ||
| <artifactId>exec-maven-plugin</artifactId> | ||
| <executions> | ||
| <execution> | ||
| <id>setuptools-clean</id> | ||
| <phase>clean</phase> | ||
| <goals> | ||
| <goal>exec</goal> | ||
| </goals> | ||
| <configuration> | ||
| <executable>${python.interpreter.bin}</executable> | ||
| <arguments> | ||
| <argument>setup.py</argument> | ||
| <argument>clean</argument> | ||
Contributor There was a problem hiding this comment. how comprehensive is this clean? e.g., does it delete random files created by tox or lint, etc? I think we want to go as far as we can here. for example, I wonder if we shouldn't be deleting all the files we added to apache rat plugin ignore below -- I don't think they're checked in. MemberAuthor There was a problem hiding this comment. that's a good point, @dhalperi for the moment I'm just doing a | ||
| </arguments> | ||
| </configuration> | ||
| </execution> | ||
| <execution> | ||
| <id>setuptools-build</id> | ||
| <phase>compile</phase> | ||
| <goals> | ||
| <goal>exec</goal> | ||
| </goals> | ||
| <configuration> | ||
| <executable>${python.interpreter.bin}</executable> | ||
| <arguments> | ||
| <argument>setup.py</argument> | ||
| <argument>build</argument> | ||
| <argument>--build-base</argument> | ||
| <argument>${python.build.base}</argument> | ||
| </arguments> | ||
| </configuration> | ||
| </execution> | ||
| <execution> | ||
| <id>setup-test-create-python-base</id> | ||
| <phase>process-test-resources</phase> | ||
| <goals> | ||
| <goal>exec</goal> | ||
| </goals> | ||
| <configuration> | ||
| <executable>mkdir</executable> | ||
| <arguments> | ||
| <argument>-p</argument> | ||
| <argument>${python.user.base}</argument> | ||
| </arguments> | ||
| </configuration> | ||
| </execution> | ||
| <execution> | ||
| <id>setup-test-tox</id> | ||
| <phase>process-test-resources</phase> | ||
| <goals> | ||
| <goal>exec</goal> | ||
| </goals> | ||
| <configuration> | ||
| <executable>${python.pip.bin}</executable> | ||
| <arguments> | ||
| <argument>install</argument> | ||
| <argument>--user</argument> | ||
| <argument>--upgrade</argument> | ||
| <argument>--ignore-installed</argument> | ||
| <argument>tox</argument> | ||
| </arguments> | ||
| <environmentVariables> | ||
| <PYTHONUSERBASE>${python.user.base}</PYTHONUSERBASE> | ||
| </environmentVariables> | ||
| </configuration> | ||
| </execution> | ||
| <execution> | ||
| <id>setuptools-test</id> | ||
| <phase>test</phase> | ||
| <goals> | ||
| <goal>exec</goal> | ||
| </goals> | ||
| <configuration> | ||
| <executable>${python.user.base}/bin/tox</executable> | ||
| <arguments> | ||
| <argument>-e</argument> | ||
| <argument>py27</argument> | ||
| <argument>-c</argument> | ||
| <argument>tox.ini</argument> | ||
| </arguments> | ||
| <environmentVariables> | ||
| <PYTHONUSERBASE>${python.user.base}</PYTHONUSERBASE> | ||
| </environmentVariables> | ||
| </configuration> | ||
| </execution> | ||
| <execution> | ||
| <id>setuptools-sdist</id> | ||
| <phase>package</phase> | ||
| <goals> | ||
| <goal>exec</goal> | ||
| </goals> | ||
| <configuration> | ||
| <executable>${python.interpreter.bin}</executable> | ||
| <arguments> | ||
| <argument>setup.py</argument> | ||
| <argument>sdist</argument> | ||
| <argument>--dist-dir</argument> | ||
| <argument>${project.build.directory}</argument> | ||
| </arguments> | ||
| <environmentVariables> | ||
| <PYTHONUSERBASE>${python.user.base}</PYTHONUSERBASE> | ||
| </environmentVariables> | ||
| </configuration> | ||
| </execution> | ||
| </executions> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
| </project> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python distribution will package this file and not any of its parents. Could you add a comment somewhere here that, in Python we use this to read the version string and and it is fine to package as a standalone file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll add a comment in the
MANIFEST.infile.