Uh oh!
There was an error while loading. Please reload this page.
[BEAM-124] Spark Running WordCountIT Example - #769
Conversation
markflyhigh
commented
Aug 2, 2016
jasonkuster
commented
Aug 2, 2016
Are we modifying wordcount so that it counts the words in the apache license instead of the shakespeare example? |
markflyhigh
commented
Aug 2, 2016
For the reason of SparkRunner can't resolve |
jasonkuster
commented
Aug 2, 2016
Sure, makes sense to me. |
jasonkuster
commented
Aug 8, 2016
"Unable to find any files matching gs://dataflow-samples/apache/LICENSE" from the Jenkins output - looks like until we get that updated this will break presubmits. |
markflyhigh
commented
Aug 8, 2016
@jasonkuster Sorry for point it out. I don't have write access right to "gs://dataflow-samples/", can you give me the authentication or help me upload the file? |
| public static class InputFactory implements DefaultValueFactory<String> { | ||
| @Override | ||
| public String create(PipelineOptions options) { | ||
| if (options.getRunner().isAssignableFrom(SparkRunner.class)) { |
There was a problem hiding this comment.
Do we want to have everyone use GCS by default?
What if Dataflow was the only one that used the GCS one?
Also, this sets a poor precedent where there is "runner" specific configuration being done on a per test basis.
There was a problem hiding this comment.
Yes, we want everyone use GCS by default, and FilnkRunner already support it. But WordCountIT can't use SparkRunner with path starting with "gs://" as for as I know. This is one tmp solution in order to aggregate this E2E test to pre/post-submit test. Otherwise, SparkRunner side will be a blocker.
There was a problem hiding this comment.
Can we construct the input file path in WordCountIT, and pass it to WordCount?
There was a problem hiding this comment.
yes, use --inputFile flag. Put this key value pair inside -DintegrationTestPipelineOptions.
lukecwik
commented
Aug 9, 2016
R: @lukecwik |
markflyhigh
commented
Aug 9, 2016
Working with @dhalperi to put new test data in a proper directory. |
1e6ec6e to
e979c82ComparePTAL @lukecwik
|
lukecwik
commented
Aug 9, 2016
LGTM, will merge once jenkins/travis runs finish |
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
gs://right now.gs://apache-beam-samples/apache/LICENSEFollowing command is used to run WordCountIT with SparkRunner:
mvn clean verify -pl examples/java -DskipITs=false -Dit.test=WordCountIT -DintegrationTestPipelineOptions='[ "--tempRoot=/tmp", "--runner=org.apache.beam.runners.spark.SparkRunner" ]'This PR is duplicated from PR(#703), since we want to have Flink and Spark in separate review.