Skip to content

[BEAM-6554] Adjust Jenkins directory for spotbugs report - #7970

Merged
kennknowles merged 1 commit into
apache:masterfrom
kennknowles:spotbugs
Mar 1, 2019
Merged

[BEAM-6554] Adjust Jenkins directory for spotbugs report#7970
kennknowles merged 1 commit into
apache:masterfrom
kennknowles:spotbugs

Conversation

@kennknowles

@kennknowleskennknowles commented Mar 1, 2019

Copy link
Copy Markdown
Member

Spotbugs has a compatible XML format, but puts the output in a different location.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

LangSDKApexDataflowFlinkGearpumpSamzaSpark
GoBuild Status------------------
JavaBuild StatusBuild StatusBuild StatusBuild Status
Build Status
Build Status		Build StatusBuild StatusBuild Status
PythonBuild Status
Build Status		---Build Status
Build Status		Build Status---------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@kennknowles

kennknowles commented Mar 1, 2019

Copy link
Copy Markdown
MemberAuthor

R: @adude3141

adude3141
adude3141 reviewed Mar 1, 2019
View reviewed changes
Comment thread.test-infra/jenkins/job_PreCommit_Java.groovy
@@ -42,7 +42,7 @@ builder.build {
pattern('**/build/reports/checkstyle/*.xml')
}
findBugs {

@adude3141adude3141Mar 1, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to switch to spot bugs here?

Jenkins plugin also has that spotBugs() symbol (see [1], #81)

[1] https://github.com/jenkinsci/warnings-ng-plugin/blob/master/SUPPORTED-FORMATS.md

@adude3141

adude3141 commented Mar 1, 2019

Copy link
Copy Markdown
Contributor

Run Java PreCommit

@adude3141

adude3141 commented Mar 1, 2019

Copy link
Copy Markdown
Contributor

Apart from this, reports are available on Jenkins status page.

LGTM. Thx!

@adude3141

adude3141 commented Mar 1, 2019

Copy link
Copy Markdown
Contributor

Ah, stupid me.... we would need to run seed job first. Currently the 'results' are just the warning 'no files found'

still LGTM, though

@kennknowles

kennknowles commented Mar 1, 2019

Copy link
Copy Markdown
MemberAuthor

Ah. I didn't realize I could switch findbugs to spotbugs. I'll do that too.

@kennknowles

kennknowles commented Mar 1, 2019

Copy link
Copy Markdown
MemberAuthor

run seed job

@kennknowles

kennknowles commented Mar 1, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

https://builds.apache.org/job/beam_SeedJob/3553/console

ERROR: Found multiple extensions which provide method spotBugs with arguments [job_PreCommit_Java$_run_closure1$_closure2$_closure3$_closure5$_closure7@390d42b]: [[io.jenkins.plugins.analysis.warnings.FindBugs, io.jenkins.plugins.analysis.warnings.SpotBugs]]

@kennknowles

kennknowles commented Mar 1, 2019

Copy link
Copy Markdown
MemberAuthor

Let's switch back to restore the signal and see if we care to fix that issue.

@kennknowles

kennknowles commented Mar 1, 2019

Copy link
Copy Markdown
MemberAuthor

run seed job

@kennknowles

kennknowles commented Mar 1, 2019

Copy link
Copy Markdown
MemberAuthor

run java precommit

@adude3141

adude3141 commented Mar 1, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Well, at least now I know, why you kept that findBugs^^

Sorry for the confusion. Had expected that to simply work. I ll dig into the dsl plugin if I find the time...

@kennknowles

kennknowles commented Mar 1, 2019

Copy link
Copy Markdown
MemberAuthor

beam9 disconnected

@kennknowles

kennknowles commented Mar 1, 2019

Copy link
Copy Markdown
MemberAuthor

run java precommit

@kennknowles
kennknowles merged commit 1a0407a into apache:masterMar 1, 2019
@kennknowles
kennknowles deleted the spotbugs branch March 1, 2019 19:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adude3141adude3141adude3141 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kennknowles@adude3141