Skip to content

Also test registration of standard coders. - #8236

Merged
robertwb merged 1 commit into
apache:masterfrom
robertwb:standard-coders
Apr 8, 2019
Merged

Also test registration of standard coders.#8236
robertwb merged 1 commit into
apache:masterfrom
robertwb:standard-coders

Conversation

@robertwb

Copy link
Copy Markdown
Contributor

Noticed this while reviewing a PR.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

LangSDKApexDataflowFlinkGearpumpSamzaSpark
GoBuild Status------------------
JavaBuild StatusBuild StatusBuild StatusBuild Status
Build Status
Build Status
Build StatusBuild StatusBuild Status
PythonBuild Status
Build Status
---Build Status
Build Status
Build Status---------

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsite
Non-portableBuild StatusBuild StatusBuild StatusBuild Status
Portable---Build Status------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@robertwb

Copy link
Copy Markdown
ContributorAuthor

R: @ihji

mxm
mxm approved these changes Apr 5, 2019

@mxmmxm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. What was the PR? ;) I think I need to adapt my implementation here #8209 to support recursive coders.

ihji
ihji approved these changes Apr 5, 2019

@ihjiihji left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@robertwb

Copy link
Copy Markdown
ContributorAuthor

#8205 (and also thinking about the StringUtf8 one).

@robertwb
robertwb merged commit bc872dc into apache:masterApr 8, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@robertwb@ihji@mxm