Uh oh!
There was an error while loading. Please reload this page.
Make RowCoder a sub-class of SchemaCoder<Row> - #9424
Merged
Conversation
TheNeuralBit
commented
Aug 27, 2019
MemberAuthor
R: @reuvenlax could you review this or suggest someone else? |
Uh oh!
There was an error while loading. Please reload this page.
... so that it can be used as the java implementation of beam:coder:row:v1 in a later change All of its remaining functionality has been moved to SchemaCoder and RowCoderGenerator.
TheNeuralBitforce-pushed
the
row-coder-swap
branch
from
September 27, 2019 23:26
ad52f7d to
c134f0aCompareMemberAuthor
Rebased onto master, and split out the |
reuvenlax
commented
Oct 4, 2019
Contributor
still appears to be conflicting files? |
TheNeuralBit
commented
Oct 4, 2019
MemberAuthor
Oh probably because #9446 was just merged. I'll fix it now. |
TheNeuralBit
commented
Oct 4, 2019
Comment on lines
+276
to
+293
| private static class RowIdentity implements SerializableFunction<Row, Row> { | ||
| @Override | ||
| public Row apply(Row input) { | ||
| return input; | ||
| } | ||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(getClass()); | ||
| } | ||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) { | ||
| return true; | ||
| } | ||
| return o != null && getClass() == o.getClass(); | ||
| } |
MemberAuthor
There was a problem hiding this comment.
Note I moved this RowIdentity class here just to make CloudObjectsTest happy until #9493 is in, and we can pass in some real SchemaCoder instances created by the providers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... so that it can be used as the java implementation of
beam:coder:row:v1in a later changeSome of
RowCoder's functionality has been removed (estimatedSizeBytes),and some has been moved to
SchemaCoderandRowCoderGenerator.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.