Skip to content

[BEAM-8148] Allow arguments to be passed to python tests from tox cli - #9474

Merged
robertwb merged 1 commit into
apache:masterfrom
chadrik:tox_posargs
Sep 4, 2019
Merged

[BEAM-8148] Allow arguments to be passed to python tests from tox cli#9474
robertwb merged 1 commit into
apache:masterfrom
chadrik:tox_posargs

Conversation

@chadrik

@chadrikchadrik commented Sep 4, 2019

Copy link
Copy Markdown
Contributor

I don't know how to specify individual tests using gradle, and as a python developer, it's way too opaque for me to figure out on my own.

The developer wiki suggest calling the tests directly:

python setup.py nosetests --tests <module>:<test class>.<test method>

But this defeats the purpose of using tox, which is there to help users manage the myriad virtual envs required to run the different tests. Luckily, there is an easier way.

With this PR you can now do:

tox -e py27 -- --tests apache_beam.testing.synthetic_pipeline_test

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

LangSDKApexDataflowFlinkGearpumpSamzaSpark
GoBuild Status------Build Status------Build Status
JavaBuild StatusBuild StatusBuild StatusBuild Status
Build Status
Build Status
Build StatusBuild StatusBuild Status
Build Status
PythonBuild Status
Build Status
Build Status
Build Status
---Build Status
Build Status
Build Status------Build Status
XLang---------Build Status---------

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsite
Non-portableBuild StatusBuild StatusBuild StatusBuild Status
Portable---Build Status------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@chadrik

Copy link
Copy Markdown
ContributorAuthor

R: @robertwb
R: @mxm
R: @aaltay

@robertwbrobertwb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this will be useful.

@chadrik

Copy link
Copy Markdown
ContributorAuthor

Yep, someone with committer credentials should update the wiki once this goes in.

@robertwb
robertwb merged commit 1f3415e into apache:masterSep 4, 2019
@chadrik

Copy link
Copy Markdown
ContributorAuthor

Thanks @robertwb

Here's the link to the wiki article I was referring to https://cwiki.apache.org/confluence/display/BEAM/Python+Tips

@mxm

mxm commented Sep 4, 2019

Copy link
Copy Markdown
Contributor

Awesome, thanks!

@aaltay

Copy link
Copy Markdown
Member

@chadrik
chadrik deleted the tox_posargs branch September 13, 2019 19:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@chadrik@mxm@aaltay@robertwb