Uh oh!
There was an error while loading. Please reload this page.
[BEAM-8148] Allow arguments to be passed to python tests from tox cli - #9474
Merged
Conversation
chadrik
commented
Sep 4, 2019
ContributorAuthor
robertwb
approved these changes
Sep 4, 2019
robertwb
left a comment
Contributor
There was a problem hiding this comment.
Thanks, this will be useful.
chadrik
commented
Sep 4, 2019
ContributorAuthor
Yep, someone with committer credentials should update the wiki once this goes in. |
chadrik
commented
Sep 4, 2019
ContributorAuthor
Thanks @robertwb Here's the link to the wiki article I was referring to https://cwiki.apache.org/confluence/display/BEAM/Python+Tips |
mxm
commented
Sep 4, 2019
Contributor
Awesome, thanks! |
aaltay
commented
Sep 4, 2019
Member
I updated https://cwiki.apache.org/confluence/display/BEAM/Python+Tips Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know how to specify individual tests using gradle, and as a python developer, it's way too opaque for me to figure out on my own.
The developer wiki suggest calling the tests directly:
But this defeats the purpose of using tox, which is there to help users manage the myriad virtual envs required to run the different tests. Luckily, there is an easier way.
With this PR you can now do:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.