Skip to content

Fix slice inference to not always assume List. - #9486

Merged
robertwb merged 1 commit into
apache:masterfrom
robertwb:no-infer-list
Sep 5, 2019
Merged

Fix slice inference to not always assume List.#9486
robertwb merged 1 commit into
apache:masterfrom
robertwb:no-infer-list

Conversation

@robertwb

@robertwbrobertwb commented Sep 5, 2019

Copy link
Copy Markdown
Contributor

R: @chadrik

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

LangSDKApexDataflowFlinkGearpumpSamzaSpark
GoBuild Status------Build Status------Build Status
JavaBuild StatusBuild StatusBuild StatusBuild Status
Build Status
Build Status
Build StatusBuild StatusBuild Status
Build Status
PythonBuild Status
Build Status
Build Status
Build Status
---Build Status
Build Status
Build Status------Build Status
XLang---------Build Status---------

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsite
Non-portableBuild StatusBuild StatusBuild StatusBuild Status
Portable---Build Status------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@robertwb

Copy link
Copy Markdown
ContributorAuthor

Run Python PreCommit

@chadrik

Copy link
Copy Markdown
Contributor

Looks good!

This is really powerful stuff. I see now why you were disappointed by the lack of inference from mypy.

@robertwb

Copy link
Copy Markdown
ContributorAuthor

Thanks.

Yes, the inference here is not as powerful in some ways as the whole-program inference that mypy, etc. does, but for passing through types through simple lambdas (something very natural for Beam) it is quite useful.

@robertwb
robertwb merged commit f747159 into apache:masterSep 5, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@robertwb@chadrik