Skip to content

[BEAM-8204][BEAM-8205] Exclude AvroSchemaTest for Apex and Flink runner for now - #9541

Merged
markflyhigh merged 2 commits into
apache:masterfrom
robinyqiu:master
Sep 11, 2019
Merged

[BEAM-8204][BEAM-8205] Exclude AvroSchemaTest for Apex and Flink runner for now#9541
markflyhigh merged 2 commits into
apache:masterfrom
robinyqiu:master

Conversation

@robinyqiu

@robinyqiurobinyqiu commented Sep 11, 2019

Copy link
Copy Markdown
Contributor

Exclude the test because they are currently breaking post-commit tests.

The test was added in #9454

r: @TheNeuralBit@reuvenlax

Post-Commit Tests Status (on master branch)

LangSDKApexDataflowFlinkGearpumpSamzaSpark
GoBuild Status------Build Status------Build Status
JavaBuild StatusBuild StatusBuild StatusBuild Status
Build Status
Build Status
Build StatusBuild StatusBuild Status
Build Status
PythonBuild Status
Build Status
Build Status
Build Status
---Build Status
Build Status
Build Status------Build Status
XLang---------Build Status---------

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsite
Non-portableBuild StatusBuild StatusBuild StatusBuild Status
Portable---Build Status------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@robinyqiu

Copy link
Copy Markdown
ContributorAuthor

Run Flink ValidatesRunner

@robinyqiu

Copy link
Copy Markdown
ContributorAuthor

Run Apex ValidatesRunner

@robinyqiu

Copy link
Copy Markdown
ContributorAuthor

Run Flink ValidatesRunner

@robinyqiu

Copy link
Copy Markdown
ContributorAuthor

Run Apex ValidatesRunner

@reuvenlax

reuvenlax commented Sep 11, 2019 via email

Copy link
Copy Markdown
Contributor

@TheNeuralBit

Copy link
Copy Markdown
Member

I'm not really up to speed on what's going on here, but both Apex and Flink seem upset about coders of two different types, if that helps. From the Flink run:

org.apache.beam.sdk.Pipeline$PipelineExecutionException: org.apache.flink.api.common.InvalidProgramException: Cannot union inputs of different types. 

and from the Apex run:

org.apache.apex.api.Launcher$LauncherException: java.lang.UnsupportedOperationException: ParMultiDo(Anonymous): Multiple side inputs with different coders.

@robinyqiu

Copy link
Copy Markdown
ContributorAuthor

Yes, and full error messages are here and here.

@markflyhighmarkflyhigh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Robin to keep ValidatesRunner test green. This PR LGTM.

@TheNeuralBit

Copy link
Copy Markdown
Member

+1 LGTM. I think @reuvenlax is right that #9446's addition of SchemaCoder.equals may fix this, but it's not fully baked yet. I think we should just skip until we can get the equality check right and un-skip these.

@reuvenlax

reuvenlax commented Sep 11, 2019 via email

Copy link
Copy Markdown
Contributor

@markflyhigh

Copy link
Copy Markdown
Contributor

Got enough lgtm. I'll merge this.

@markflyhigh
markflyhigh merged commit 8f91984 into apache:masterSep 11, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@robinyqiu@reuvenlax@TheNeuralBit@markflyhigh