Skip to content

[BEAM-7060] Cherry-pick #9562: Prefer inspect module over funcsigs - #9591

Merged
markflyhigh merged 1 commit into
apache:release-2.16.0from
markflyhigh:release-2.16.0
Sep 20, 2019
Merged

[BEAM-7060] Cherry-pick #9562: Prefer inspect module over funcsigs#9591
markflyhigh merged 1 commit into
apache:release-2.16.0from
markflyhigh:release-2.16.0

Conversation

@markflyhigh

Copy link
Copy Markdown
Contributor

In Python 3 with funcsigs installed, prefer inspect.{signature,Paramter}
over funcsigs equivalents.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

LangSDKApexDataflowFlinkGearpumpSamzaSpark
GoBuild Status------Build Status------Build Status
JavaBuild StatusBuild StatusBuild StatusBuild Status
Build Status
Build Status
Build StatusBuild StatusBuild Status
Build Status
PythonBuild Status
Build Status
Build Status
Build Status
---Build Status
Build Status
Build Status------Build Status
XLang---------Build Status---------

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsite
Non-portableBuild StatusBuild StatusBuild StatusBuild Status
Portable---Build Status------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

In Python 3 with funcsigs installed, prefer inspect.{signature,Paramter}
over funcsigs equivalents.
@markflyhigh

Copy link
Copy Markdown
ContributorAuthor

+R: @udim

@udim

udim commented Sep 19, 2019

Copy link
Copy Markdown
Member

@markflyhigh please let us know if the precommit failures are ok to ignore in the release branch. The docs task failure is being handled in #9620

@markflyhigh

Copy link
Copy Markdown
ContributorAuthor

I think the failure in Python Precommit can be ignore since it comes from Dataflow service side (once new container is built for this release, dataflow test should be unblocked). This change is fully tested against master so I think it's safe to cherry-pick.

@markflyhigh
markflyhigh merged commit 24e74b9 into apache:release-2.16.0Sep 20, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@markflyhigh@udim