Skip to content

[BEAM-8165] use default tag - #9610

Merged
yifanzou merged 2 commits into
apache:masterfrom
Hannah-Jiang:container
Sep 18, 2019
Merged

[BEAM-8165] use default tag#9610
yifanzou merged 2 commits into
apache:masterfrom
Hannah-Jiang:container

Conversation

@Hannah-Jiang

@Hannah-JiangHannah-Jiang commented Sep 18, 2019

Copy link
Copy Markdown
Contributor

Use default tag which is latest instead of version.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

LangSDKApexDataflowFlinkGearpumpSamzaSpark
GoBuild Status------Build Status------Build Status
JavaBuild StatusBuild StatusBuild StatusBuild Status
Build Status
Build Status
Build StatusBuild StatusBuild Status
Build Status
PythonBuild Status
Build Status
Build Status
Build Status
---Build Status
Build Status
Build Status------Build Status
XLang---------Build Status---------

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsite
Non-portableBuild StatusBuild StatusBuild StatusBuild Status
Portable---Build Status------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@Hannah-Jiang

Copy link
Copy Markdown
ContributorAuthor

Run JavaPortabilityApi PreCommit

@Hannah-Jiang

Copy link
Copy Markdown
ContributorAuthor

R: @yifanzou

@yifanzou

Copy link
Copy Markdown
Contributor

The code looks good. A few questions: What would the default tag look like? Doesn't python images use the default tags?

@Hannah-Jiang

Hannah-Jiang commented Sep 18, 2019

Copy link
Copy Markdown
ContributorAuthor

The code looks good. A few questions: What would the default tag look like? Doesn't python images use the default tags?

Default tag is latest, which is defined here.
Python doesn't use default tag because it can read version from version.py.

@Hannah-Jiang

Copy link
Copy Markdown
ContributorAuthor

Run Python PreCommit

@yifanzou
yifanzou merged commit 909bc5a into apache:masterSep 18, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Hannah-Jiang@yifanzou@hannahjiang-0415