Uh oh!
There was an error while loading. Please reload this page.
[BEAM-8279] Disable IOTypeHints.from_callable - #9611
Conversation
udim
commented
Sep 19, 2019
run python 3.7 postcommit |
markflyhigh
commented
Sep 19, 2019
Run Python PreCommit |
robertwb
left a comment
There was a problem hiding this comment.
This looks good assuming tests pass. Could you try importing this and verifying it's OK as well?
| _ANY_VAR_POSITIONAL = typehints.Tuple[typehints.Any, ...] | ||
| _ANY_VAR_KEYWORD = typehints.Dict[typehints.Any, typehints.Any] | ||
| # TODO(BEAM-8280): Remove this when from_callable is ready to be enabled. | ||
| _enable_from_callable = False |
There was a problem hiding this comment.
Nit: the name "from_callable" isn't very enlightening without context, perhaps something more descriptive like infer_types_from_annotations?
There was a problem hiding this comment.
Sorry I don't have time to make this change. I'll be away for 1.5 weeks starting tomorrow.
udim
commented
Sep 19, 2019
I believe the failure in sdks:python:test-suites:tox:py2:docs is unrelated |
udim
commented
Sep 19, 2019
I've already tested some internal tests that weren't passing and they pass, but I haven't done a clean import without my changes. |
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.