Skip to content

[BEAM-8279] Disable IOTypeHints.from_callable - #9611

Merged
udim merged 1 commit into
apache:masterfrom
udim:disable-from-callable
Sep 19, 2019
Merged

[BEAM-8279] Disable IOTypeHints.from_callable#9611
udim merged 1 commit into
apache:masterfrom
udim:disable-from-callable

Conversation

@udim

@udimudim commented Sep 19, 2019

Copy link
Copy Markdown
Member

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

LangSDKApexDataflowFlinkGearpumpSamzaSpark
GoBuild Status------Build Status------Build Status
JavaBuild StatusBuild StatusBuild StatusBuild Status
Build Status
Build Status
Build StatusBuild StatusBuild Status
Build Status
PythonBuild Status
Build Status
Build Status
Build Status
---Build Status
Build Status
Build Status------Build Status
XLang---------Build Status---------

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsite
Non-portableBuild StatusBuild StatusBuild StatusBuild Status
Portable---Build Status------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@udim
udim requested a review from robertwbSeptember 19, 2019 00:43
@udim

udim commented Sep 19, 2019

Copy link
Copy Markdown
MemberAuthor

run python 3.7 postcommit

@markflyhigh

Copy link
Copy Markdown
Contributor

Run Python PreCommit

@robertwbrobertwb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good assuming tests pass. Could you try importing this and verifying it's OK as well?

_ANY_VAR_POSITIONAL = typehints.Tuple[typehints.Any, ...]
_ANY_VAR_KEYWORD = typehints.Dict[typehints.Any, typehints.Any]
# TODO(BEAM-8280): Remove this when from_callable is ready to be enabled.
_enable_from_callable = False

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the name "from_callable" isn't very enlightening without context, perhaps something more descriptive like infer_types_from_annotations?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I don't have time to make this change. I'll be away for 1.5 weeks starting tomorrow.

@udim

udim commented Sep 19, 2019

Copy link
Copy Markdown
MemberAuthor

I believe the failure in sdks:python:test-suites:tox:py2:docs is unrelated

@udim

udim commented Sep 19, 2019

Copy link
Copy Markdown
MemberAuthor

This looks good assuming tests pass. Could you try importing this and verifying it's OK as well?

I've already tested some internal tests that weren't passing and they pass, but I haven't done a clean import without my changes.

@udim
udim merged commit eb76a71 into apache:masterSep 19, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@udim@markflyhigh@robertwb