Uh oh!
There was an error while loading. Please reload this page.
[BEAM-8224] Fix bug in _fn_takes_side_inputs (#9563) - #9623
Merged
Conversation
Bug was introduced in the conversion to inspect.signature, and manifests as assigning a wrapper function that accepts a single positional argument when the wrapped function can accept an arbitrary number.
udim
commented
Sep 20, 2019
MemberAuthor
R: @markflyhigh |
markflyhigh
commented
Sep 20, 2019
Contributor
LGTM |
markflyhigh
commented
Sep 20, 2019
Contributor
The docs task failure is being handled in #9620. Cython failure is not related to this change and integration test is caused by dataflow service. This change is fully tested when merging to master so should be safe to cherry-pick. |
markflyhigh
requested review from
markflyhigh
and removed request for
markflyhighSeptember 20, 2019 04:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherrypick of #9563
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.