[CALCITE-6582] Release Calcite 1.38.0 - #3979
Conversation
mihaibudiu
left a comment
There was a problem hiding this comment.
This includes fixes from two different issues, (besides the release itself), which is unusual.
It would have been simpler to merge these as separate PR, but I guess this way we don't have to wait for the authors.
There are lots of space-only changes in the history file.
fdf32e2 to
806b468
Compare
Add release notes. In the release notes for previous releases, change whitespace and formatting for consistency among releases, standardize on 'Postgres' rather than 'PostgreSQL', and move the 'Compatability' paragraph before the 'Breaking changes' section. Add users' aliases to .mailmap, so that the contributors list in the release notes contains people's real name. In howto, suggest using JDK 21 for release. Fix a typo in FileReaderTest. Close apache#3979
806b468 to
7412138
Compare
Add release notes. In the release notes for previous releases, change whitespace and formatting for consistency among releases, standardize on 'Postgres' rather than 'PostgreSQL', and move the 'Compatability' paragraph before the 'Breaking changes' section. Add users' aliases to .mailmap, so that the contributors list in the release notes contains people's real name. In howto, suggest using JDK 21 for release. Fix a typo in FileReaderTest. Close apache#3979
7412138 to
d3d309f
Compare
zabetak
left a comment
There was a problem hiding this comment.
Went over the release notes and everything looks good.
| Tim Grein, | ||
| TJ Banghart, | ||
| Wegdan Ghazi, | ||
| xiaohei, |
There was a problem hiding this comment.
It seems that xiaohei and suibianwanwan are the same person but I couldn't trace it back to a real name.
- xiaohei 1597226206@qq.com
- suibianwanwan suibianwanwan33@foxmail.com
There was a problem hiding this comment.
Yes, I changed the name to suibianwanwan in later commit
There was a problem hiding this comment.
Provide a patch to the .mailmap file in a reply in this comment thread and I will include it.
Also consider using git config to make your identity more consistent. It is helpful for us committers to know which person we are dealing with.
There was a problem hiding this comment.
Done
suibianwanwan <suibianwanwan33@foxmail.com> # aka xiaohei
Thank you, I will do that
There was a problem hiding this comment.
This is what I needed:
diff --git a/.mailmap b/.mailmap
index 7ce4e7016..965a3b9fc 100644
--- a/.mailmap
+++ b/.mailmap
@@ -133,6 +133,8 @@ Shuo Cheng <shuo.cs@alibaba-inc.com>
Slim Bouguerra <slim.bouguerra@gmail.com>
Stamatis Zampetakis <15013153+zabetak@users.noreply.github.com>
Stamatis Zampetakis <zabetak@gmail.com>
+suibianwanwan <1597226206@qq.com>
+suibianwanwan <suibianwanwan33@foxmail.com>
Taras Ledkov <tledkov@gridgain.com>
Ted Xu (少杰) <shaojie@alibaba-inc.com>
Venki Korukanti <venki.korukanti@gmail.com>
There was a problem hiding this comment.
I got it, Thank for the tweak.
| Wegdan Ghazi, | ||
| xiaohei, | ||
| Xiong Duan, | ||
| YiwenWu, |
There was a problem hiding this comment.
It seems that the name is Yiwen Wu and I found the following entries in the git log:
- YiwenWu yiwenwu@tencent.com
- YiwenWu yiwenwu1006@gmail.com
| * [<a href="https://issues.apache.org/jira/browse/CALCITE-6365">CALCITE-6365</a>] | ||
| Support `RETURNING` clause of `JSON_QUERY` function | ||
|
|
||
| New functions: |
There was a problem hiding this comment.
nit: This section does not have the usual header highlighting and reference link; not sure if it is intentional.
…at RelBuilder$Frame init The cause was compiling the release candidate using JDK 21, which caused the `interface SequencedCollection`, introduced in JDK 21, to be used in resolving methods. The fix is to revert to JDK 8 for the release build. We suspect that building with building with JDK 11 or 17 would also work.
|
@julianhyde CALCITE-6617 has reported two independent problems in a single issue. Here your last commit includes a fix for the second problem. I will create a new JIRA issue and a PR for the first problem reported. Since you considered 6617 a blocker, I will let you decide whether you want to include this fix as well. |
|
@mihaibudiu, I just pushed a commit with a couple of test cases - no fix. This is a dev branch and I will squash and re-sequence commits when a fix is available. The issues in 6617 all seem to be related to comparing fixed-point and floating-point numbers, so I would like a fix for all parts if possible. A good description of the problems will help a lot. Without a good description I am flying blind. |
|
I have filed https://issues.apache.org/jira/browse/CALCITE-6620 and the corresponding fix #4000. |
Fix the tag URL, add an end time for the vote, describe how to use 'code name (role)' vote format, sign using release manager's name.
f38c7a9 to
71f731e
Compare
Add release notes. In the release notes for previous releases, change whitespace and formatting for consistency among releases, standardize on 'Postgres' rather than 'PostgreSQL', and move the 'Compatability' paragraph before the 'Breaking changes' section. Add users' aliases to .mailmap, so that the contributors list in the release notes contains people's real name. In howto, suggest using JDK 21 for release. Fix a typo in FileReaderTest. Close apache#3979
Add release notes. In the release notes for previous releases, change whitespace and formatting for consistency among releases, standardize on 'Postgres' rather than 'PostgreSQL', and move the 'Compatability' paragraph before the 'Breaking changes' section. Add users' aliases to .mailmap, so that the contributors list in the release notes contains people's real name. Fix a typo in FileReaderTest. Release candidate #1 introduced [CALCITE-6616] ClassNotFoundException: java.util.SequencedCollection at RelBuilder$Frame init The cause was compiling the release candidate using JDK 21, which caused the `interface SequencedCollection`, introduced in JDK 21, to be used in resolving methods. The fix (in release candidate #2) is to revert to JDK 8 for the release build (and revert the instructions in howto.md). We suspect that building with building with JDK 11 or 17 would also work. Revise template vote email. Fix the tag URL, add an end time for the vote, describe how to use 'code name (role)' vote format, sign using release manager's name. Close apache#3979
|
Add release notes. In the release notes for previous releases, change whitespace and formatting for consistency among releases, standardize on 'Postgres' rather than 'PostgreSQL', and move the 'Compatability' paragraph before the 'Breaking changes' section. Add users' aliases to .mailmap, so that the contributors list in the release notes contains people's real name. Fix a typo in FileReaderTest. Release candidate #1 introduced [CALCITE-6616] ClassNotFoundException: java.util.SequencedCollection at RelBuilder$Frame init The cause was compiling the release candidate using JDK 21, which caused the `interface SequencedCollection`, introduced in JDK 21, to be used in resolving methods. The fix (in release candidate #2) is to revert to JDK 8 for the release build (and revert the instructions in howto.md). We suspect that building with building with JDK 11 or 17 would also work. Revise template vote email. Fix the tag URL, add an end time for the vote, describe how to use 'code name (role)' vote format, sign using release manager's name. Close #3979
No description provided.