Skip to content

OPTIQ-296: re-organized package structure to org.apache.optiq... - #4

Closed
marcprux wants to merge 1 commit into
apache:masterfrom
marcprux:package-reorg
Closed

OPTIQ-296: re-organized package structure to org.apache.optiq...#4
marcprux wants to merge 1 commit into
apache:masterfrom
marcprux:package-reorg

Conversation

@marcprux

@marcprux marcprux commented Jul 8, 2014

Copy link
Copy Markdown
Member

No description provided.

@asfgit asfgit closed this in a640e58 Dec 10, 2014
zhumayun pushed a commit to zhumayun/calcite that referenced this pull request May 22, 2017
# This is the 1st commit message:
Added thetaSketch data type to DruidTypes

# This is the commit message apache#2:

Fixed code to comply with checkstyle

# This is the commit message apache#3:

Implemented thetaSketch and hyperUnique DruidTypes by adding an extra map to hold column type information

# This is the commit message apache#4:

bug fix: used fieldName as key, rather than output name

# This is the commit message apache#5:

Fixed test errors

# This is the commit message apache#6:

Fixed DruidTableFactory to include the proper druid types. (Fixes Integration test issues as well)
zhumayun pushed a commit to zhumayun/calcite that referenced this pull request May 22, 2017
# This is the 1st commit message:
no message

# This is the commit message apache#2:

Added test case to check for COUNT aggregate without DISTINCT for metrics of type hyperUnique

# This is the commit message apache#3:

Changed comment format

# This is the commit message apache#4:

added thetaSketch metric to food mart model definition so that thetaSketches can be tested

# This is the commit message apache#5:

Updated old test cases to take into account new thetaSketch metric (user_unique) for foodmart
wangpanCN pushed a commit to wangpanCN/calcite that referenced this pull request Oct 25, 2019
hsyuan added a commit that referenced this pull request Jan 23, 2020
Some times RelSet can get merged. e.g.

Each number represet Rel id, and they are in different RelSet.

 1            4
   \         /
     2      /
       \   /
         3
Assume in the rulequeue, we have rule match with name of 12, 23, 43. For
simplicity, omit the rule name, first digit represent the parent RelNode,
second represent the child.

If after some rule, we merged the set of 3 into the set of 2, and RelNode 4's
input is replaced by RelSubset of 2. We will retrigger rules and try to add
rulematch 12, 42, 43 into rule queue.

12 will be filtered out, because there is duplicate in the RuleMatch names set.
But for 43, it now has different rulematch digest with previous match, because
RelNode #4's input RelSubset changed, its digest also changed. So we can't
detect the duplication and will re-apply rulematch 43 twice.
wangxlong pushed a commit to wangxlong/calcite that referenced this pull request Feb 13, 2020
Some times RelSet can get merged. e.g.

Each number represet Rel id, and they are in different RelSet.

 1            4
   \         /
     2      /
       \   /
         3
Assume in the rulequeue, we have rule match with name of 12, 23, 43. For
simplicity, omit the rule name, first digit represent the parent RelNode,
second represent the child.

If after some rule, we merged the set of 3 into the set of 2, and RelNode 4's
input is replaced by RelSubset of 2. We will retrigger rules and try to add
rulematch 12, 42, 43 into rule queue.

12 will be filtered out, because there is duplicate in the RuleMatch names set.
But for 43, it now has different rulematch digest with previous match, because
RelNode apache#4's input RelSubset changed, its digest also changed. So we can't
detect the duplication and will re-apply rulematch 43 twice.
hbtoo pushed a commit to hbtoo/calcite that referenced this pull request Oct 2, 2020
… merged

Some times RelSet can get merged. e.g.

Each number represet Rel id, and they are in different RelSet.

 1            4
   \         /
     2      /
       \   /
         3
Assume in the rulequeue, we have rule match with name of 12, 23, 43. For
simplicity, omit the rule name, first digit represent the parent RelNode,
second represent the child.

If after some rule, we merged the set of 3 into the set of 2, and RelNode 4's
input is replaced by RelSubset of 2. We will retrigger rules and try to add
rulematch 12, 42, 43 into rule queue.

12 will be filtered out, because there is duplicate in the RuleMatch names set.
But for 43, it now has different rulematch digest with previous match, because
RelNode apache#4's input RelSubset changed, its digest also changed. So we can't
detect the duplication and will re-apply rulematch 43 twice.
olivrlee referenced this pull request in olivrlee/calcite Nov 11, 2022
tjbanghart added a commit to tjbanghart/calcite that referenced this pull request Jul 12, 2026
- Add TpchWCOJBenchmarkCli with three query shapes (self-join triangle,
  self-join 4-cycle, FK triangle) and five execution modes (baseline,
  wcoj, combine-binary, combine, combine-share)
- Add TpchQueryExplorer for candidate query exploration
- Add gradle tasks (runTpchWcojBenchmark, exploreTpchQueries)
- Archive all benchmark results to CSV including combine-binary data
- Fix population -> sample stddev (÷N-1) in both benchmark CLIs

Paper revisions addressing three rounds of peer review:
- Add TPC-H Section 7.2.4 with Tables 5-6, full SQL for all queries
- Add Table 6 with FK regression results (WCOJ 1.5-3.6x slower)
- Add combine-binary ablation column isolating batching vs WCOJ
- Add sample stddev ± to all tables with CV>20% dagger markers
- Fix "super-linear" claim to "grows faster than WCOJ"
- Clarify TrieCache sharing scope (intra-operator vs cross-operator)
- Strengthen Theorem 1 proof to condition on Combine-Share mode
- Add cost model limitations paragraph (per-level intersection cost)
- Add memory considerations for spooling
- Add MULTI() design alternatives and standardization discussion
- Soften "first in open-source" to "to our knowledge"
- Add explicit connected-graph assumption for cyclicity test
- Add variance source attribution (GC/page cache for TPC-H)
- Add speedup uncertainty caveats for high-variance baselines
- Update contribution apache#4 to mention TPC-H evaluation

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant