Uh oh!
There was an error while loading. Please reload this page.
CASSANDRA-19292 Enable Jenkins to test against Cassandra 4.1.x - #1924
Merged
Conversation
absurdfarce
commented
Apr 3, 2024
| + " sstables int,\n" | ||
| + " total bigint,\n" | ||
| + " unit text,\n" | ||
| + " PRIMARY KEY (keyspace_name, table_name, task_id)\n" |
ContributorAuthor
There was a problem hiding this comment.
Table changed slightly with 4.1.x:
- task_id became a timeuuid
- sstables field was introduced
absurdfarce
commented
Apr 3, 2024
| @@ -236,12 +236,33 @@ public void create() { | |||
| Arrays.stream(nodes).mapToObj(n -> "" + n).collect(Collectors.joining(":")), | |||
ContributorAuthor
There was a problem hiding this comment.
All changes in this file aim to address configuration changes in Cassandra 4.1 brought in by CASSANDRA-15234
absurdfarce
commented
Apr 3, 2024
| if (originalKey.endsWith(IN_MS_STR)) return originalValueStr + "ms"; | ||
| if (originalKey.endsWith(IN_KB_STR)) return originalValueStr + "KiB"; | ||
| return originalValueStr; | ||
| } |
ContributorAuthor
There was a problem hiding this comment.
Not intended to be an exhaustive set of changes required to support CASSANDRA-15234. For now I'm just worried about the set of props necessary to support the current collection of ITs; we can always update this as necessary if new configs need to be added for future test customization.
adutra
approved these changes
Apr 4, 2024
aratno
approved these changes
Apr 19, 2024
Merged
patch by Bret McGuire; reviewed by Bret McGuire, Alexandre Dutra for CASSANDRA-19292
absurdfarceforce-pushed
the
cassandra19506
branch
from
April 24, 2024 04:49
dbe893e to
4878373Compare
This was referenced Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confirmed that with this PR we get a green run of a per-commit build using existing DataStax Jenkins infrastructure