Skip to content

Add support for execution profiles in execute_concurrent. - #1122

Merged
absurdfarce merged 1 commit into
apache:masterfrom
andy-slac:concurrent-execution-profiles
Mar 16, 2022
Merged

Add support for execution profiles in execute_concurrent.#1122
absurdfarce merged 1 commit into
apache:masterfrom
andy-slac:concurrent-execution-profiles

Conversation

@andy-slac

Copy link
Copy Markdown
Contributor

Adds one more keyword argument execution_profile to the
execute_concurrent method to pass an execution profile. It is fowarded
to Session.execute_async call.

Adds one more keyword argument `execution_profile` to the
`execute_concurrent` method to pass an execution profile. It is fowarded
to `Session.execute_async` call.
@andy-slac

andy-slac commented Mar 7, 2022

Copy link
Copy Markdown
ContributorAuthor

This is a trivial change to allow passing a non-default execution profile to execute_concurrent. I did not add a unit test for this new argument, but I tested it with my own code. Would be nice to have this merged eventually.

@absurdfarce

Copy link
Copy Markdown
Contributor

@andy-slac Thanks for the contribution!

Have you signed the Contributor License Agreement for contributions to DataStax open source projects? If not you can find it at https://cla.datastax.com/. Thanks!

@andy-slac

Copy link
Copy Markdown
ContributorAuthor

Thanks, I have just signed the CLA.

@absurdfarce

Copy link
Copy Markdown
Contributor

Awesome, thanks @andy-slac !

I did a bit of local testing with this PR and everything looks pretty good.

Thanks again for the contribution!

@absurdfarce
absurdfarce merged commit 8c4c653 into apache:masterMar 16, 2022
@andy-slac

Copy link
Copy Markdown
ContributorAuthor

Thank you, @absurdfarce!

fruch added a commit to fruch/python-driver that referenced this pull request Aug 2, 2022
…to sync_with_upstream
* 'master' of https://github.com/datastax/python-driver:
Merge pull request apache#1126 from eamanu/fix-typos
PYTHON-1294: Upgrade importlib-metadata to a much newer version
Add tests for recent addition of execution profile support to cassandra.concurrent
Merge pull request apache#1122 from andy-slac/concurrent-execution-profiles
Merge pull request apache#1119 from datastax/python-1290
Merge pull request apache#1117 from datastax/remove_unittest2
Removing file unexpectedly included in previous PR
Merge pull request apache#1114 from haaawk/stream_ids_fix
Merge pull request apache#1116 from Orenef11/fix_default_argument_value
Comment update following off of apache#1110
Merge pull request apache#1103 from numberly/fix_empty_paging
Merge pull request apache#1103 from psarna/fix_deprecation_in_tracing
Fixes to the Travis build. (apache#1111)
fruch added a commit to fruch/python-driver that referenced this pull request Aug 2, 2022
…to sync_with_upstream_2
* 'master' of https://github.com/datastax/python-driver:
Merge pull request apache#1126 from eamanu/fix-typos
PYTHON-1294: Upgrade importlib-metadata to a much newer version
Add tests for recent addition of execution profile support to cassandra.concurrent
Merge pull request apache#1122 from andy-slac/concurrent-execution-profiles
Merge pull request apache#1119 from datastax/python-1290
Merge pull request apache#1117 from datastax/remove_unittest2
Removing file unexpectedly included in previous PR
Merge pull request apache#1114 from haaawk/stream_ids_fix
Merge pull request apache#1116 from Orenef11/fix_default_argument_value
Comment update following off of apache#1110
Merge pull request apache#1103 from numberly/fix_empty_paging
Merge pull request apache#1103 from psarna/fix_deprecation_in_tracing
Fixes to the Travis build. (apache#1111)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@andy-slac@absurdfarce