Uh oh!
There was an error while loading. Please reload this page.
clean up last "import six" - #1197
Conversation
absurdfarce
commented
Feb 27, 2024
Thanks for the PR @a-detiste! I agree it would be nice to tighten up these last few areas in order to get six completely out of the code base. Have you signed the Contributor License Agreement for contributions to DataStax open source projects? If not you can find it at https://cla.datastax.com/. Thanks! |
a-detiste
commented
Feb 27, 2024
Hi, I ve signed the CLA. |
| # Install Python Dependencies for CCM. | ||
| Start-Process python -ArgumentList "-m pip install psutil pyYaml six numpy" -Wait -NoNewWindow | ||
| Start-Process python -ArgumentList "-m pip install psutil pyYaml numpy" -Wait -NoNewWindow |
There was a problem hiding this comment.
This one probably should stay. The usage here is to add the dependencies that ccm needs (in order to support starting and stopping clusters for unit tests) and as of this writing it does still require six. It's not a huge thing since we don't really rely on AppVeyor much at the moment but I also don't want to delete it as it might cause some level of confusion later.
absurdfarce
left a comment
There was a problem hiding this comment.
Good changes overall, but I think we do want to keep the usage in the AppVeyor PS code.
a-detiste
commented
Feb 27, 2024
I force pushed to remove the change |
absurdfarce
commented
Feb 27, 2024
Excellent, thanks for the quick turnaround @a-detiste ! I think we're ready to go here! |
…sync_with_upstream_3.29.1 version 3.29.1 * tag '3.29.1' of https://github.com/datastax/python-driver: Release 3.29.1: changelog & version (apache#1199) PYTHON-1378 Expand search directories for includes (apache#1198) clean up last "import six" (apache#1197) fix build from source on macos using homebrew (apache#1196) Added 3.29.0 to docs.yaml
…sync_with_upstream_3.29.1 version 3.29.1 * tag '3.29.1' of https://github.com/datastax/python-driver: Release 3.29.1: changelog & version (apache#1199) PYTHON-1378 Expand search directories for includes (apache#1198) clean up last "import six" (apache#1197) fix build from source on macos using homebrew (apache#1196) Added 3.29.0 to docs.yaml
No description provided.