Uh oh!
There was an error while loading. Please reload this page.
Removed future print_function, division, and with_statement and some pre 3.7 handling - #1208
Conversation
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| from __future__ import division |
There was a problem hiding this comment.
Per PEP-238 the effect of this future import in 2.x was to enforce true division "throughout a module". In Python3 / is understood to mean true division generally... so there is no impact to this removal t'all.
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| from __future__ import with_statement |
There was a problem hiding this comment.
Per PEP-343 this became standard syntax in 2.6... this could've been removed long ago. :(
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| from __future__ import print_function |
There was a problem hiding this comment.
I'm not sure... this one is actually used anywhere. Regardless it's absolutely safe to remove for Python3.
| # integer division used here to emulate built-in total_seconds | ||
| return ((86400 * td.days + td.seconds) * 10 ** 6 + td.microseconds) / 10 ** 6 | ||
| def get_total_seconds(td): | ||
| return td.total_seconds() |
There was a problem hiding this comment.
Hey @bschoening, this one is also removed by another PR that I'm looking to merge in order to clean up the mock usages. Would you mind rebasing this against master once I get that PR in? Should go in later today.
There was a problem hiding this comment.
To follow up: the other PR has been merged. Should be a pretty straightforward conflict resolution @bschoening ... I'm really hoping I didn't inadvertently mess you up here. :(
bschoening
commented
May 30, 2024
@absurdfarce updated the PR so it has no merge conficts. |
absurdfarce
commented
May 31, 2024
Thanks as always @bschoening ! |
Removed unnecessary future print_function, division, and with and some pre 3.0 handling
Does not touch __future__imports!