Uh oh!
There was an error while loading. Please reload this page.
Remove a leftover code - #1222
Merged
Merged
Conversation
absurdfarce
commented
Aug 20, 2024
Contributor
Nice catch @dkropachev ! If I recall correctly this was added originally because the repr() op used in the conversion string for the ValueError in the next line was failing... and I was trying to get at the actual error string. But I might be wrong about all of that. :) Regardless, you're absolutely correct, this code doesn't need to be here now that repr() for vector types should work correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was part of #1161.
Looks like some excessive debug code that was overlooked by @absurdfarce