Uh oh!
There was an error while loading. Please reload this page.
Package: extract install script generation to template file - #95
Merged
Conversation
tuhaihe
marked this pull request as draft
April 28, 2026 06:57
Extract install script generation from Makefile to a separate template file for better maintainability and readability. - Add install.sh.template with Apache License header - Simplify Makefile package target using sed for template substitution
woblerr
reviewed
May 14, 2026
Uh oh!
There was an error while loading. Please reload this page.
woblerr
self-requested a review
May 15, 2026 06:54
woblerr
approved these changes
May 15, 2026
woblerr
commented
May 15, 2026
Collaborator
LGTM |
leborchuk
approved these changes
May 15, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #ISSUE_Number
Change logs
Contributor's checklist
Here are some reminders before you submit your pull request: