Skip to content

Package: extract install script generation to template file - #95

Merged
tuhaihe merged 2 commits into
apache:mainfrom
tuhaihe:update-install.sh
May 15, 2026
Merged

Package: extract install script generation to template file#95
tuhaihe merged 2 commits into
apache:mainfrom
tuhaihe:update-install.sh

Conversation

@tuhaihe

Copy link
Copy Markdown
Member

closes: #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what document is being added or updated.

Contributor's checklist

Here are some reminders before you submit your pull request:

@tuhaihe
tuhaihe marked this pull request as draft April 28, 2026 06:57
Extract install script generation from Makefile to a separate template
file for better maintainability and readability.
- Add install.sh.template with Apache License header
- Simplify Makefile package target using sed for template substitution
@tuhaihe
tuhaiheforce-pushed the update-install.sh branch from 230e511 to 6f8aabcCompareMay 14, 2026 09:02
@tuhaihe
tuhaihe marked this pull request as ready for review May 14, 2026 09:02
@tuhaihe
tuhaihe requested review from ostinru and woblerrMay 14, 2026 09:09
Comment thread.github/workflows/cloudberry-backup-ci.yml Outdated
@woblerr
woblerr self-requested a review May 15, 2026 06:54
@woblerr

Copy link
Copy Markdown
Collaborator

LGTM

@tuhaihe
tuhaihe merged commit 2f74ca9 into apache:mainMay 15, 2026
11 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tuhaihe@woblerr@leborchuk