Uh oh!
There was an error while loading. Please reload this page.
Automatically generate node support functions in cloudberry - #1823
Automatically generate node support functions in cloudberry#1823chenjinbao1989 wants to merge 1 commit into
Conversation
Uh oh!
There was an error while loading. Please reload this page.
ce58074 to
472d86eCompareUh oh!
There was an error while loading. Please reload this page.
7e2e166 to
93ce112Compare93ce112 to
a1d61e9Comparetuhaihe
commented
Jun 23, 2026
The new file now includes the standard ASF license header and has passed the RAT scan. It looks fine to me. Thanks! |
tuhaihe
commented
Jun 26, 2026
Hi @chenjinbao1989 welcome to add the issue description to your commit message body for a better context. You can take the .gitmessage as a commit template. |
chenjinbao1989
commented
Jul 5, 2026
This pr does not come from a issue. It is a feature from pg16. |
tuhaihe
commented
Jul 7, 2026
Thanks for the clarification! That's totally fine. My point wasn't necessarily about having an issue, but about providing enough context in the commit message. For PostgreSQL merge work, adding the upstream background or the related PostgreSQL commit in the message body would make the history much easier to understand later. |
tuhaihe
commented
Jul 16, 2026
If no more comments, could we start to merge this PR for PG16 FIXME? |
When merging Postgres 16, automatic generation of node support
functions was not enabled. This commit enables the automatic
generation of write, read, copy, and equal functions.
In future code, developers will no longer need to manually create
NodeTags and their corresponding write/read/copy/equal functions
when creating or modifying structures.