Skip to content

Automatically generate node support functions in cloudberry - #1823

Open
chenjinbao1989 wants to merge 1 commit into
apache:mainfrom
chenjinbao1989:generate_read_write2
Open

Automatically generate node support functions in cloudberry#1823
chenjinbao1989 wants to merge 1 commit into
apache:mainfrom
chenjinbao1989:generate_read_write2

Conversation

@chenjinbao1989

Copy link
Copy Markdown
Contributor

When merging Postgres 16, automatic generation of node support
functions was not enabled. This commit enables the automatic
generation of write, read, copy, and equal functions.

In future code, developers will no longer need to manually create
NodeTags and their corresponding write/read/copy/equal functions
when creating or modifying structures.

Comment threadsrc/include/commands/explain_gp.h Outdated
@chenjinbao1989
chenjinbao1989force-pushed the generate_read_write2 branch 2 times, most recently from ce58074 to 472d86eCompareJune 18, 2026 03:11
Comment threadsrc/backend/executor/execAmi.c
@chenjinbao1989
chenjinbao1989force-pushed the generate_read_write2 branch 2 times, most recently from 7e2e166 to 93ce112CompareJune 22, 2026 14:52
@tuhaihe

Copy link
Copy Markdown
Member

The new file now includes the standard ASF license header and has passed the RAT scan. It looks fine to me. Thanks!

@tuhaihe

Copy link
Copy Markdown
Member

Hi @chenjinbao1989 welcome to add the issue description to your commit message body for a better context.

You can take the .gitmessage as a commit template.

@tuhaihetuhaihe moved this from Todo to In Progress in Merge postgres 16Jun 26, 2026
@chenjinbao1989

Copy link
Copy Markdown
ContributorAuthor

Hi @chenjinbao1989 welcome to add the issue description to your commit message body for a better context.

You can take the .gitmessage as a commit template.

This pr does not come from a issue. It is a feature from pg16.

@tuhaihe

Copy link
Copy Markdown
Member

Hi @chenjinbao1989 welcome to add the issue description to your commit message body for a better context.
You can take the .gitmessage as a commit template.

This pr does not come from a issue. It is a feature from pg16.

Thanks for the clarification!

That's totally fine. My point wasn't necessarily about having an issue, but about providing enough context in the commit message.

For PostgreSQL merge work, adding the upstream background or the related PostgreSQL commit in the message body would make the history much easier to understand later.

@tuhaihe

Copy link
Copy Markdown
Member

If no more comments, could we start to merge this PR for PG16 FIXME?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants

@chenjinbao1989@tuhaihe@yjhjstz