Skip to content

Revert "Fix explain bad indent when showing operatorMem." - #289

Merged
avamingli merged 1 commit into
mainfrom
revert-288-fix_operatorMem_indent
Nov 7, 2023
Merged

Revert "Fix explain bad indent when showing operatorMem."#289
avamingli merged 1 commit into
mainfrom
revert-288-fix_operatorMem_indent

Conversation

@avamingli

@avamingliavamingli commented Nov 7, 2023

Copy link
Copy Markdown
Contributor

Reverts #288

@avamingli

avamingli commented Nov 7, 2023

Copy link
Copy Markdown
ContributorAuthor

ORCA has some failed.

@avamingliavamingli self-assigned this Nov 7, 2023
@tuhaihe

tuhaihe commented Nov 7, 2023

Copy link
Copy Markdown
Member

Hi @avamingli, For the #288 checks failing, the job also showed when setuping upterm session, sudo: apt-get: command not found. I'm not sure if the workflow should be updated too. Just FYI.

@avamingli

avamingli commented Nov 7, 2023

Copy link
Copy Markdown
ContributorAuthor

Hi @avamingli, For the #288 checks failing, the job also showed when setuping upterm session, sudo: apt-get: command not found. I'm not sure if the workflow should be updated too. Just FYI.

I see this on other prs too, May need help from @smartyhero

@avamingliavamingli added the priority: High After critical issues are fixed, these should be dealt with before any further issues. label Nov 7, 2023
@avamingli

avamingli commented Nov 7, 2023

Copy link
Copy Markdown
ContributorAuthor

CI failed due to #262

my-ship-it
my-ship-it approved these changes Nov 7, 2023
View reviewed changes

@my-ship-itmy-ship-it left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gfphoenix78
gfphoenix78 approved these changes Nov 7, 2023
View reviewed changes

@gfphoenix78gfphoenix78 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@avamingli
avamingliforce-pushed the revert-288-fix_operatorMem_indent branch from 8000358 to 8cd7c5eCompareNovember 7, 2023 11:32
@avamingli
avamingli merged commit 18efaa6 into mainNov 7, 2023
@avamingli
avamingli deleted the revert-288-fix_operatorMem_indent branch November 7, 2023 14:08
@avamingliavamingli mentioned this pull request Nov 9, 2023
Merged
9 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gfphoenix78gfphoenix78gfphoenix78 approved these changes
@my-ship-itmy-ship-itmy-ship-it approved these changes

Assignees

@avamingliavamingli

Labels

priority: HighAfter critical issues are fixed, these should be dealt with before any further issues.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@avamingli@tuhaihe@gfphoenix78@my-ship-it