Skip to content

Use ergochat/readline - #199

Open
vishesh92 wants to merge 3 commits into
mainfrom
update-readline-and-remove-vendors
Open

Use ergochat/readline #199
vishesh92 wants to merge 3 commits into
mainfrom
update-readline-and-remove-vendors

Conversation

@vishesh92

Copy link
Copy Markdown
Member

Fixes#137 and removes vendor directory.

@github-actions

github-actionsBot commented Nov 3, 2025

Copy link
Copy Markdown

✅ Build complete for PR #199.

🔗 Download the cmk binaries (expires on January 22, 2026)

@vishesh92
vishesh92force-pushed the update-readline-and-remove-vendors branch from 97977d5 to 22a5e90CompareNovember 3, 2025 11:43

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates from the unmaintained github.com/chzyer/readline library to github.com/ergochat/readline and removes the vendor directory dependency management approach in favor of standard Go module handling.

  • Replaces chzyer/readline with ergochat/readline v0.1.3
  • Removes all vendor-related build flags and commands across build configuration files
  • Updates dependency versions (golang.org/x/sys and adds golang.org/x/text)

Reviewed Changes

Copilot reviewed 4 out of 512 changed files in this pull request and generated no comments.

FileDescription
go.modUpdates readline dependency and bumps indirect dependencies
cli/prompt.goChanges readline import to use ergochat package
MakefileRemoves -mod=vendor flags from all build commands and vendor dependencies from targets
snap/snapcraft.yamlRemoves go mod vendor command from snap build process

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@shwstppr

Copy link
Copy Markdown
Contributor

@vishesh92 there were some customisations in the existing lib, not sure they need to be included with the change.
One I did was to allow autocompletion by name of the resources

@vishesh92

Copy link
Copy Markdown
MemberAuthor

@vishesh92 there were some customisations in the existing lib, not sure they need to be included with the change.
One I did was to allow autocompletion by name of the resources

Let me compare with the upstream readline library. Do you know if there is any other library which was changed? We should ideally move away from vendor based setup.

@vishesh92
vishesh92force-pushed the update-readline-and-remove-vendors branch from d86f1f8 to eceb07fCompareNovember 5, 2025 09:07
@vishesh92

Copy link
Copy Markdown
MemberAuthor

@shwstppr I have migrated the changes in readline package to the new one and keeping the vendors directory.

@vishesh92vishesh92 changed the title Use ergochat/readline and remove vendors directoryUse ergochat/readline Nov 5, 2025

@shwstpprshwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishesh92 tested build for this PR. For some reasons prompt goes missing when autocompletion is invoked
cmk-prompt-goes-missing.webm

Screenshot from 2025-11-06 14-35-11

@shwstpprshwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Not seeing any regressions due to library change
Good to have pagination when a lot of autocomplete options
image

@DaanHooglandDaanHoogland added this to the 6.6.0 milestone Nov 17, 2025
Comment threadvendor/golang.org/x/text/LICENSE
@vishesh92
vishesh92force-pushed the update-readline-and-remove-vendors branch from 8d824e6 to 308c74aCompareJanuary 12, 2026 08:59
@vishesh92
vishesh92force-pushed the update-readline-and-remove-vendors branch from 308c74a to 4041770CompareJanuary 12, 2026 09:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Readline issues when line goes beyond screen width

5 participants

@vishesh92@shwstppr@ctubbsii@DaanHoogland