Skip to content

Document advance DRS settings - #374

Merged
yadvr merged 3 commits into
apache:4.19from
shapeblue:add-advance-drs-settings
Feb 13, 2024
Merged

Document advance DRS settings#374
yadvr merged 3 commits into
apache:4.19from
shapeblue:add-advance-drs-settings

Conversation

@vishesh92

@vishesh92vishesh92 commented Jan 18, 2024•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@vishesh92vishesh92 mentioned this pull request Jan 18, 2024
Merged
13 tasks
@vishesh92vishesh92 reopened this Jan 18, 2024
@vishesh92
vishesh92force-pushed the add-advance-drs-settings branch from aa9158c to 7c03cabCompareJanuary 18, 2024 13:14
kiranchavala
kiranchavala approved these changes Jan 25, 2024
View reviewed changes

@kiranchavalakiranchavala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the drs settings description are fine

@DaanHoogland

DaanHoogland commented Jan 25, 2024

Copy link
Copy Markdown
Contributor

@vishesh92 is this for 4.19? or next release?

@vishesh92

vishesh92 commented Jan 25, 2024

Copy link
Copy Markdown
MemberAuthor

@vishesh92 is this for 4.19? or next release?

I was thinking of getting this in 4.19.1.

sureshanaparti
sureshanaparti reviewed Jan 25, 2024
View reviewed changes
Comment threadsource/adminguide/clusters.rst Outdated
@vishesh92@sureshanaparti
Update source/adminguide/clusters.rst
d6c898b
Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
sureshanaparti
sureshanaparti reviewed Jan 25, 2024
View reviewed changes
Comment threadsource/adminguide/clusters.rst Outdated
sureshanaparti
sureshanaparti reviewed Jan 25, 2024
View reviewed changes
Comment threadsource/adminguide/clusters.rst Outdated
@vishesh92@sureshanaparti
Apply suggestions from code review
6be13c5
Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
@yadvr
yadvr changed the base branch from main to 4.19February 9, 2024 06:14
@yadvryadvr added this to the 4.19.1 milestone Feb 9, 2024
@yadvr
yadvr merged commit c4272e3 into apache:4.19Feb 13, 2024
@yadvr
yadvr deleted the add-advance-drs-settings branch February 13, 2024 05:49
DaanHoogland added a commit that referenced this pull request Apr 8, 2024
@DaanHoogland
Merge release branch 4.19 to main
f5fc6e7
* 4.19:
notes on POD-subnets (#391)
Documentation for checkVolume API (#380)
Document advance DRS settings (#374)
veeam: update API commands and versions in doc (#357)
Update virtual_machines.rst (#353)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sureshanapartisureshanapartisureshanaparti left review comments
@kiranchavalakiranchavalakiranchavala approved these changes
@DaanHooglandDaanHooglandDaanHoogland approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.19.1

Development

Successfully merging this pull request may close these issues.

5 participants

@vishesh92@DaanHoogland@kiranchavala@sureshanaparti@yadvr