Skip to content

Feature: Key Management Service (KMS) - #634

Merged
harikrishna-patnala merged 1 commit into
apache:mainfrom
shapeblue:feature-kms
Jun 30, 2026
Merged

Feature: Key Management Service (KMS)#634
harikrishna-patnala merged 1 commit into
apache:mainfrom
shapeblue:feature-kms

Conversation

@vishesh92

@vishesh92vishesh92 commented Mar 18, 2026

Copy link
Copy Markdown
Member

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds administrator documentation for the new Key Management Service (KMS) feature and wires it into the Admin Guide, including updated volume creation docs and supporting UI/architecture screenshots.

Changes:

  • Add a new Admin Guide page documenting KMS concepts (KEK/DEK), HSM profiles, key lifecycle (create/rotate), migration, and configuration settings.
  • Update storage docs to describe KVM volume encryption and expose the new “KMS Key” option when creating volumes.
  • Add new images and include the new KMS page in the Admin Guide index toctree.

Reviewed changes

Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
source/adminguide/storage.rstAdds a “Volume Encryption” section and documents the optional “KMS Key” field during volume creation.
source/adminguide/kms.rstNew KMS documentation page (architecture, providers, HSM profiles, key creation/rotation, migration, settings).
source/adminguide/index.rstAdds kms to the Admin Guide toctree so the new page is published.
source/_static/images/kms-rotate-key.pngNew screenshot referenced by KMS key rotation docs.
source/_static/images/kms-create-key.pngNew screenshot referenced by KMS key creation docs.
source/_static/images/kms-architecture.pngNew architecture diagram referenced by the KMS overview.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


.. warning::
Deleting the KMS key used to encrypt a volume will render that volume permanently
unrecoverable.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishesh92 can we block the delete operation when a KMS key in use, instead of unrecoverable volume?

@kiranchavala

Copy link
Copy Markdown
Member

@blueorangutan docbuild

@blueorangutan

Copy link
Copy Markdown

@kiranchavala a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@kiranchavala

Copy link
Copy Markdown
Member

@blueorangutan docbuild

@blueorangutan

Copy link
Copy Markdown

@kiranchavala a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/634. (QA-JID 537)

@harikrishna-patnalaharikrishna-patnala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harikrishna-patnala
harikrishna-patnala merged commit a099b8f into apache:mainJun 30, 2026
5 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@vishesh92@kiranchavala@blueorangutan@harikrishna-patnala@sureshanaparti