Skip to content

move upgrade code to the right file - #10036

Merged
DaanHoogland merged 2 commits into
4.20from
pr9759-for-4.20-followup
Dec 4, 2024
Merged

move upgrade code to the right file#10036
DaanHoogland merged 2 commits into
4.20from
pr9759-for-4.20-followup

Conversation

@DaanHoogland

Copy link
Copy Markdown
Contributor

Description

This PR addresses the 4.20.1 part of the changes needed for the upgrades.

see #9759 (comment)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov

codecovBot commented Dec 4, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.03%. Comparing base (b3dc402) to head (0ed8fb9).
Report is 8 commits behind head on 4.20.

Additional details and impacted files
@@ Coverage Diff @@## 4.20 #10036 +/- ##
=========================================
Coverage 16.03% 16.03% Complexity 12813 12813 =========================================
Files 5636 5636 Lines 493463 493463 Branches 59825 59825 =========================================
Hits 79133 79133 Misses 405554 405554 Partials 8776 8776 
FlagCoverage Δ
uitests4.02% <ø> (ø)
unittests16.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weizhouapacheweizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Comment threadengine/schema/src/main/resources/META-INF/db/schema-42000to42010.sql Outdated
…10.sql
Co-authored-by: Fabricio Duarte <fabricio.duarte.jr@gmail.com>

@BryanMLimaBryanMLima left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM

@sonarqubecloud

Copy link
Copy Markdown

@DaanHoogland
DaanHoogland merged commit 0eb94a1 into 4.20Dec 4, 2024
@DaanHoogland
DaanHoogland deleted the pr9759-for-4.20-followup branch December 4, 2024 13:30
DaanHoogland added a commit that referenced this pull request Dec 4, 2024
* 4.20:
move upgrade code to the right file (#10036)
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Dec 12, 2024
Co-authored-by: Fabricio Duarte <fabricio.duarte.jr@gmail.com>
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Dec 12, 2024
* 4.20:
move upgrade code to the right file (apache#10036)
@Pearl1594Pearl1594 moved this to Done in ACS 4.20.1Mar 17, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants

@DaanHoogland@winterhazel@BryanMLima@weizhouapache@Pearl1594