Uh oh!
There was an error while loading. Please reload this page.
[blocker/critical] CLOUDSTACK-9025 : [Xenserver] Sending template creation from snapshot command to Hypervisor - #1030
Closed
anshul1886 wants to merge 1 commit into
Closed
Conversation
… command to Hypervisor if hypervisor version is not 6.1.0 and 6.2.0 without XSHotFix62ESP1004.
anshul1886
commented
Nov 4, 2015
Author
I am going on vacation so if there are any concerns then feel free to modify it. |
DaanHoogland
commented
Nov 4, 2015
Contributor
I am not sure why this PR is marked blocker/critical. The implemented code is a nested if. It should have been a factored out check-method with unit test, not withstanding the integration test instructions in it. |
anshul1886
commented
Dec 14, 2015
Author
Closing this PR as this got fixed by PR #1176 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CLOUDSTACK-9025
In this fix we are sending command to hypervisor only if hypervisor version is not 6.1.0 and 6.2.0 without XSHotFix62ESP1004. I am not sure whether we support Xenserver 6.1.0 and 6.2.0 without XSHotFix62ESP1004. This conditional check is there to make sure users are able to upgrade in transition period. If that's not the case we can remove condition all together and can send command to hypervisor.
To test this issue we need different versions of XenServer. Versions which we are mentioning in condition in that case it should go to SSVM and in other cases it should go to Hypervsior. SSVM can't handle linked snapshots in case of XenServer.