server: fetch IP of VMs on L2 networks by weizhouapache · Pull Request #10431 · apache/cloudstack

weizhouapache · 2025-02-19T15:55:52Z

Description

This PR fixes an issue with #10376 , and adds the support to get vm IP for VMs on L2 network via qemu-guest-agent

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache · 2025-02-19T15:56:33Z

@blueorangutan package

blueorangutan · 2025-02-19T15:58:03Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2025-02-19T16:04:20Z

Codecov Report

Attention: Patch coverage is 64.58333% with 17 lines in your changes missing coverage. Please review.

Project coverage is 15.17%. Comparing base (f50de89) to head (cf8f2fc).
Report is 53 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	0.00%	8 Missing ⚠️
...e/wrapper/LibvirtGetVmIpAddressCommandWrapper.java	82.85%	2 Missing and 4 partials ⚠️
...ava/com/cloud/agent/api/GetVmIpAddressCommand.java	40.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## 4.19 #10431 +/- ##
=========================================
Coverage 15.16% 15.17% - Complexity 11329 11331 +2 
=========================================
Files 5413 5413 Lines 474782 474811 +29 Branches 57903 57907 +4 =========================================
+ Hits 72010 72032 +22 - Misses 394722 394725 +3 - Partials 8050 8054 +4

Flag	Coverage Δ
uitests	`4.29% <ø> (ø)`
unittests	`15.89% <64.58%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2025-02-19T16:51:32Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12514

weizhouapache · 2025-02-19T18:25:14Z

@blueorangutan package

blueorangutan · 2025-02-19T18:26:03Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-02-19T19:27:23Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12515

weizhouapache · 2025-02-19T19:54:40Z

@blueorangutan test

blueorangutan · 2025-02-19T19:56:03Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-02-20T09:25:30Z

[SF] Trillian test result (tid-12475)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 46169 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10431-t12475-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

Pearl1594 · 2025-02-20T14:45:48Z

@weizhouapache can you please check if this PR does the same as what #10376 is doing?

weizhouapache · 2025-02-20T15:11:32Z

@weizhouapache can you please check if this PR does the same as what #10376 is doing?

As suggested by @NuxRo , I cherry-picked 10376 into this PR so we can test together.

github-actions · 2025-02-28T07:29:30Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

weizhouapache · 2025-03-03T11:04:30Z

@blueorangutan package

blueorangutan · 2025-03-03T11:06:05Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-03-03T12:04:05Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12635

weizhouapache · 2025-03-03T15:07:52Z

@blueorangutan package

blueorangutan · 2025-03-03T15:10:03Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-03-03T16:05:10Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12638

NuxRo · 2025-03-04T11:29:59Z

Looking good so far @weizhouapache !

weizhouapache · 2025-03-04T14:14:07Z

Looking good so far @weizhouapache !

thanks for the testing @NuxRo !

weizhouapache · 2025-03-18T08:22:17Z

@blueorangutan package

blueorangutan · 2025-03-18T08:24:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-03-18T09:46:46Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12817

NuxRo

lgtm

DaanHoogland

clgtm

yadvr · 2025-05-09T04:54:34Z

@blueorangutan package

blueorangutan · 2025-05-09T04:56:06Z

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-05-09T06:21:15Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13309

DaanHoogland · 2025-05-09T08:20:17Z

(btw merged because @NuxRo stated that he meant he tested it in #10431 (review) , so its his fault)

boring-cyborgBot added the component:kvm label Feb 19, 2025

DaanHoogland added this to the 4.19.3 milestone Feb 20, 2025

weizhouapache mentioned this pull request Feb 28, 2025
add use of virsh domifaddr to get VM external DHCP IP #10376
Merged
14 tasks

github-actionsBot added the status:has-conflicts label Feb 28, 2025

server: fetch IP of VMs on L2 networks
5f1e11f

weizhouapache force-pushed the 4.19-fetch-vm-ip-l2-network branch from dc40a33 to 5f1e11fCompare February 28, 2025 07:32

github-actionsBot removed the status:has-conflicts label Feb 28, 2025

yadvr modified the milestones: 4.19.3, 4.20.1 Feb 28, 2025

weizhouapache changed the title ~~server: fetch IP of VMs on L2 networks~~[WIP] server: fetch IP of VMs on L2 networksFeb 28, 2025

PR10341: init
a056021

PR10341: fetch VM IP by checking mac address
cf8f2fc

boring-cyborgBot added component:api component:XenServer labels Mar 3, 2025

weizhouapache marked this pull request as ready for review March 4, 2025 14:13

weizhouapache changed the title ~~[WIP] server: fetch IP of VMs on L2 networks~~server: fetch IP of VMs on L2 networksMar 4, 2025

Pearl1594 requested review from DaanHoogland and NuxRo March 4, 2025 14:21

Pearl1594 added this to ACS 4.20.1 Mar 17, 2025

Pearl1594 moved this to In Progress in ACS 4.20.1 Mar 17, 2025

weizhouapache mentioned this pull request Mar 29, 2025
VMware: match nic mac for ip address fetch #10641
Merged
14 tasks

weizhouapache linked an issue Mar 29, 2025 that may be closed by this pull request
Autodetect IPs used inside the VM #7142
Open

NuxRo approved these changes May 3, 2025
View reviewed changes

DaanHoogland approved these changes May 5, 2025
View reviewed changes

DaanHoogland merged commit ea32a1a into apache:4.19May 9, 2025

github-project-automationBot moved this from In Progress to Done in ACS 4.20.1 May 9, 2025

DaanHoogland deleted the 4.19-fetch-vm-ip-l2-network branch May 9, 2025 08:20

DaanHoogland modified the milestones: 4.20.1, 4.19.3 May 9, 2025

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
server: fetch IP of VMs on L2 networks (apache#10431)
ae5cbe1

Uh oh!

Conversation

weizhouapache commented Feb 19, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

weizhouapache commented Feb 19, 2025

Uh oh!

blueorangutan commented Feb 19, 2025

Uh oh!

codecovBot commented Feb 19, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Feb 19, 2025

Uh oh!

weizhouapache commented Feb 19, 2025

Uh oh!

blueorangutan commented Feb 19, 2025

Uh oh!

blueorangutan commented Feb 19, 2025

Uh oh!

weizhouapache commented Feb 19, 2025

Uh oh!

blueorangutan commented Feb 19, 2025

Uh oh!

blueorangutan commented Feb 20, 2025

Uh oh!

Pearl1594 commented Feb 20, 2025

Uh oh!

weizhouapache commented Feb 20, 2025

Uh oh!

github-actionsBot commented Feb 28, 2025

Uh oh!

weizhouapache commented Mar 3, 2025

Uh oh!

blueorangutan commented Mar 3, 2025

Uh oh!

blueorangutan commented Mar 3, 2025

Uh oh!

weizhouapache commented Mar 3, 2025

Uh oh!

blueorangutan commented Mar 3, 2025

Uh oh!

blueorangutan commented Mar 3, 2025

Uh oh!

NuxRo commented Mar 4, 2025

Uh oh!

weizhouapache commented Mar 4, 2025

Uh oh!

weizhouapache commented Mar 18, 2025

Uh oh!

blueorangutan commented Mar 18, 2025

Uh oh!

blueorangutan commented Mar 18, 2025

Uh oh!

NuxRo left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented May 9, 2025

Uh oh!

blueorangutan commented May 9, 2025

Uh oh!

blueorangutan commented May 9, 2025

Uh oh!

DaanHoogland commented May 9, 2025

Uh oh!

Reviewers

Assignees

Labels

weizhouapache commented Feb 19, 2025•
edited
Loading

codecovBot commented Feb 19, 2025•
edited
Loading