Skip to content

Netris Network Plugin Integration with CloudStack - #10458

Merged
sureshanaparti merged 107 commits into
mainfrom
netris-integration-upstream
Jul 25, 2025
Merged

Netris Network Plugin Integration with CloudStack#10458
sureshanaparti merged 107 commits into
mainfrom
netris-integration-upstream

Conversation

@Pearl1594

@Pearl1594Pearl1594 commented Feb 24, 2025•
edited by nvazquez
Loading

Copy link
Copy Markdown
Contributor

Description

This PR adds a new network plugin - Netris

The Netris Plugin introduces Netris as a network service provider in CloudStack to be able to create and manage Virtual Private Clouds (VPCs) in CloudStack, being able to orchestrate the following network functionalities:

  • Network segmentation with Netris-VXLAN isolation method
  • Routing between "public" IP and network segments with an ACS ROUTED mode offering
  • SourceNAT, DNAT, 1:1 NAT between "public" IP and network segments with an ACS NATTED mode offering
  • Routing between VPC network segments (tiers in ACS nomenclature)
  • Access Lists (ACLs) between VPC tiers and "public" network (TCP, UDP, ICMP) both as global egress rules and "public" IP specific ingress rules.
  • ACLs between VPC network tiers (TCP, UDP, ICMP)
  • External load balancing – between VPC network tiers and "public" IP
  • Internal load balancing – between VPC network tiers
  • CloudStack Virtual Router services (DHCP, DNS, UserData, Password Injection, etc…)

Doc PR: apache/cloudstack-documentation#482

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov

codecovBot commented Feb 24, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 29.93161% with 2664 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.76%. Comparing base (22b753e) to head (b333d06).
⚠️ Report is 123 commits behind head on main.

Files with missing linesPatch %Lines
...a/org/apache/cloudstack/service/NetrisElement.java11.84%435 Missing and 4 partials ⚠️
...g/apache/cloudstack/service/NetrisServiceImpl.java4.28%333 Missing and 2 partials ⚠️
...ain/java/com/cloud/network/vpc/VpcManagerImpl.java1.56%311 Missing and 3 partials ⚠️
...org/apache/cloudstack/resource/NetrisResource.java43.28%144 Missing and 8 partials ⚠️
...va/com/cloud/network/element/NetrisProviderVO.java0.00%135 Missing ⚠️
...che/cloudstack/service/NetrisGuestNetworkGuru.java32.98%101 Missing and 27 partials ⚠️
...java/com/cloud/network/SDNProviderNetworkRule.java46.25%122 Missing ⚠️
...tack/agent/api/CreateOrUpdateNetrisACLCommand.java0.00%65 Missing ⚠️
.../cloudstack/service/NetrisProviderServiceImpl.java44.14%58 Missing and 4 partials ⚠️
...va/com/cloud/network/netris/NetrisNetworkRule.java3.77%51 Missing ⚠️
... and 96 more
Additional details and impacted files
@@ Coverage Diff @@## main #10458 +/- ##
============================================
+ Coverage 3.89% 16.76% +12.86% - Complexity 0 14285 +14285 
============================================
Files 417 5767 +5350 Lines 33973 512731 +478758 Branches 6097 62391 +56294 ============================================
+ Hits 1324 85953 +84629 - Misses 32491 417180 +384689 - Partials 158 9598 +9440
FlagCoverage Δ
uitests3.85% <ø> (-0.05%)⬇️
unittests17.68% <29.93%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Pearl1594Pearl1594 modified the milestone: 4.21.0Feb 24, 2025
@github-actions

github-actionsBot commented Feb 25, 2025

Copy link
Copy Markdown

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@nvazquez
nvazquezforce-pushed the netris-integration-upstream branch from a795f88 to 0890a9aCompareFebruary 28, 2025 14:02
@borisstoyanov

borisstoyanov commented Feb 28, 2025

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

blueorangutan commented Feb 28, 2025

Copy link
Copy Markdown

@borisstoyanov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Feb 28, 2025

Copy link
Copy Markdown

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12617

Pearl1594and others added 11 commits February 28, 2025 09:30
@Pearl1594
fix failing build
ada9fc7
@Pearl1594
Support for listing VPCs (#5)
4ac2dc5
@nvazquez@Pearl1594
List tenants
56617da
@nvazquez@Pearl1594
Delegate API classes creation to the SDK and simply invoke the desire…
a3dd9a1
…d API class through CloudStack (#7)
* Delegate API classes creation to the SDK and simply invoke the desired API class through CloudStack
* Pass default auth scheme for now
@Pearl1594
Support adding netris provider to CloudStack and Netris VPC Creation (#6
737cd69
)
* Support adding netris provider to CloudStack
* revert marvin change
* add license and perform session check when provider is added
* add license and remove unused import
* fix build failure - uunused imports
* address comments
* fix provider name
* add Netris network element
* add license
* Add netris management APIs and netris service provider
* add license
* revert change
* remove other network elements from Netris element
* fix api name in doc generator
* remove logs
* move session alive check to CheckHealthCommand exec
* Fix zone creation wizard to configure netris provider
* Upgrade GSON version - from PR 8756
* Add additional parametes to the add Netris provider API
* add netris as a host
* add additional params to the resoponse and update UI
* Rename site to site_name
* Create Netris VPC (#8)
* Delegate API classes creation to the SDK and simply invoke the desired API class through CloudStack (#7)
* Delegate API classes creation to the SDK and simply invoke the desired API class through CloudStack
* Pass default auth scheme for now
* Drop for_nsx and for_tungten columns in favour of checking the provider on the ntwserviceprovider map table
* Remove missing setForTungsten occurrence
* Remove forNsx from VPC offerings
* Create Netris VPC
* Fix VPC offerings listing and remove unused dao
* Create VPC fixes
* Upgrade GSON version - from PR 8756
* Fix VPC creation response by using the latest SDK code
* Fix unit test
* Remove unused import
* Fix NSX unit tests after refactoring
* Add Netris key to the VLAN Details table (#10)
* Add Netris key to the VLAN Details table
* update for_<provider> column to be generic
* Fix VPC and add IPAM allocation for the VPC CIDR (#9)
* Fix VPC and add IPAM allocation for the VPC CIDR
* Remove VPC logic
* Use zoneId accountId and domainId on resources creation
* Fix naming
* Fix VR public nic issue
* Fix Netris Public IP for VPC source NAT allocation
* Add Netris VPC Subnets and vNets (#11)
* Add Netris VPC Subnets and vNets
* fix compilation errors
* Add netris subnet
* refactor naming convention to differentiate between VPC tiers and Isolated networks
* revert marvin change
* fix constructor - build failure
* Add support to filter netris offerings, delete netris provider when zone is being deleted
* Fix build
* Fix VPC creation
* Fix vnet creation
* unnecesary log
Authored-by: Pearl Dsilva <pearl1594@gmail.com>
@nvazquez@Pearl1594
Fix unit tests
e9415db
@Pearl1594@nvazquez
Add support to delete VNets and Subnets (#13)
7cf2da3
* Add support to delete VNets and Subnets
* Add support to delete vnet resources
* Add support to delete vnet resources
* extract code to method
---------
Co-authored-by: nvazquez <nicovazquez90@gmail.com>
@Pearl1594
Add missing suffix return (#14)
4610d10
@nvazquez@Pearl1594
Set up Netris Public range on new zone addition (#15)
a27eca3
* Set up Netris Public range on new zone addition
* Add dependency to calculate subnet containing a start and end IP
* Remove unused import
* Move dependency to the netris module
* Rename Netris IP range
* Refactor logic
* Revert "Refactor logic"
This reverts commit 7ec36a81320444c37e7bb914dd895060b663411b.
* Fix setup range after adding Netris Provider
* Fix VXLAN range adding on zone creation
@Pearl1594
Pass VXLAN ID during creation of Netris vNets (#16)
5a606c5
* add zone params to accepts management vnet
* Release vxlan associated to the netris broadcast domain type
* handle update network broadcast uri
@Pearl1594
Update Subnet purpose for Netris Public Traffic (#17)
f927971
* Update Subnet purpose for Netris Public Traffic
* search for existing subnet of common purpose type
@Pearl1594

Pearl1594 commented Jul 24, 2025

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan package

@blueorangutan

blueorangutan commented Jul 24, 2025

Copy link
Copy Markdown

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Jul 24, 2025

Copy link
Copy Markdown

[SF] Trillian test result (tid-13864)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 63520 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10458-t13864-kvm-ol8.zip
Smoke tests completed. 134 look OK, 8 have errors, 0 did not run
Only failed and skipped tests results shown below:

TestResultTime (s)Test File
test_01_non_strict_host_anti_affinityFailure150.91test_nonstrict_affinity_group.py
test_02_non_strict_host_affinityError91.05test_nonstrict_affinity_group.py
test_01_add_primary_storage_disabled_hostError39.70test_primary_storage.py
test_01_primary_storage_scope_changeError0.10test_primary_storage_scope.py
test_01_sys_vm_startFailure0.10test_secondary_storage.py
ContextSuite context=TestCpuCapServiceOfferings>:setupError0.00test_service_offerings.py
test_01_deploy_vm_on_specific_hostError0.15test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_clusterError0.15test_vm_deployment_planner.py
ContextSuite context=TestDeployVMFromSnapshotOrVolume>:setupError0.00test_vm_lifecycle_with_snapshot_or_volume.py
test_06_download_detached_volumeFailure318.89test_volumes.py

@blueorangutan

blueorangutan commented Jul 24, 2025

Copy link
Copy Markdown

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 14348

@github-project-automationgithub-project-automationBot moved this from In Progress to Done in Apache CloudStack 4.21.0Jul 24, 2025
@Pearl1594Pearl1594 reopened this Jul 24, 2025
@Pearl1594Pearl1594 moved this from Done to In Progress in Apache CloudStack 4.21.0Jul 24, 2025
@Pearl1594

Pearl1594 commented Jul 24, 2025

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan package

@blueorangutan

blueorangutan commented Jul 24, 2025

Copy link
Copy Markdown

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Jul 24, 2025

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14354

@sureshanaparti

sureshanaparti commented Jul 24, 2025

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

blueorangutan commented Jul 24, 2025

Copy link
Copy Markdown

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Jul 25, 2025

Copy link
Copy Markdown

[SF] Trillian test result (tid-13878)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 60543 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10458-t13878-kvm-ol8.zip
Smoke tests completed. 141 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

TestResultTime (s)Test File
test_list_zones_metricsError0.25test_metrics_api.py

@github-project-automationgithub-project-automationBot moved this from In Progress to Done in Apache CloudStack 4.21.0Jul 25, 2025
@sureshanapartisureshanaparti moved this from Done to In Progress in Apache CloudStack 4.21.0Jul 25, 2025
@sureshanaparti
sureshanaparti merged commit 0d4147f into mainJul 25, 2025
96 of 115 checks passed
@github-project-automationgithub-project-automationBot moved this from In Progress to Done in Apache CloudStack 4.21.0Jul 25, 2025
@sureshanaparti
sureshanaparti deleted the netris-integration-upstream branch July 25, 2025 09:57
@sonarqubecloud

sonarqubecloudBot commented Jul 25, 2025

Copy link
Copy Markdown

Quality Gate FailedQuality Gate failed

Failed conditions
15.2% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 1, 2025
@Pearl1594@dhslove
Netris Network Plugin Integration with CloudStack (apache#10458)
4fa33e1
The Netris Plugin introduces Netris as a network service provider in CloudStack to be able to create and manage Virtual Private Clouds (VPCs) in CloudStack, being able to orchestrate the following network functionalities:
- Network segmentation with Netris-VXLAN isolation method
- Routing between "public" IP and network segments with an ACS ROUTED mode offering
- SourceNAT, DNAT, 1:1 NAT between "public" IP and network segments with an ACS NATTED mode offering
- Routing between VPC network segments (tiers in ACS nomenclature)
- Access Lists (ACLs) between VPC tiers and "public" network (TCP, UDP, ICMP) both as global egress rules and "public" IP specific ingress rules.
- ACLs between VPC network tiers (TCP, UDP, ICMP)
- External load balancing – between VPC network tiers and "public" IP
- Internal load balancing – between VPC network tiers
- CloudStack Virtual Router services (DHCP, DNS, UserData, Password Injection, etc…)
@weizhouapacheweizhouapache mentioned this pull request Aug 20, 2025
Open
@weizhouapacheweizhouapache mentioned this pull request Nov 3, 2025
Closed
@weizhouapacheweizhouapache mentioned this pull request Dec 1, 2025
Merged
14 tasks
@DaanHooglandDaanHoogland removed their assignment Dec 24, 2025
@weizhouapacheweizhouapache mentioned this pull request May 7, 2026
Merged
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHooglandDaanHooglandDaanHoogland left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@nvazqueznvazqueznvazquez approved these changes
@sureshanapartisureshanapartisureshanaparti approved these changes
@weizhouapacheweizhouapacheAwaiting requested review from weizhouapache

Assignees

No one assigned

Labels

component:apicomponent:vpctype:new-feature

Projects

No open projects
Apache CloudStack 4.21.0
Status: Done

Milestone

4.21.0

Development

Successfully merging this pull request may close these issues.

8 participants

@Pearl1594@borisstoyanov@blueorangutan@nvazquez@weizhouapache@sureshanaparti@DaanHoogland