Skip to content

test: fix failure in test_06_purge_expunged_vm_background_task - #10501

Merged
shwstppr merged 1 commit into
apache:4.20from
shapeblue:fix-purgebg-test
Mar 6, 2025
Merged

test: fix failure in test_06_purge_expunged_vm_background_task#10501
shwstppr merged 1 commit into
apache:4.20from
shapeblue:fix-purgebg-test

Conversation

@shwstppr

Copy link
Copy Markdown
Contributor

Description

Failures seen in
#10006 (comment) and others.

With #9773, the response of listManagementServers API has been changed. serviceip has been renamed to ipaddress. THis was causing not all MS getting restarted and purge b/g task not being able to run. The code handling API response in the test has been updated.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@boring-cyborgboring-cyborgBot added component:integration-test Python Warning... Python code Ahead! labels Mar 5, 2025
@shwstppr
shwstppr requested a review from Pearl1594March 5, 2025 08:00
@shwstpprshwstppr added this to the 4.20.1 milestone Mar 5, 2025
@shwstppr
shwstppr requested a review from abh1sarMarch 5, 2025 08:01
Failures seen in
apache#10006 (comment)
and others.
With apache#9773, the response of
listManagementServers API has been changed. serviceip has been renamed
to ipaddress. THis was causing not all MS getting restarted and purge
b/g task not being able to run. The code handling API response in the
test has been updated.
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov

codecovBot commented Mar 5, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.00%. Comparing base (80b5d5c) to head (36c8061).
Report is 3 commits behind head on 4.20.

Additional details and impacted files
@@ Coverage Diff @@## 4.20 #10501 +/- ##
=========================================
Coverage 16.00% 16.00% - Complexity 13104 13105 +1 
=========================================
Files 5651 5651 Lines 495862 495862 Branches 60043 60043 =========================================
+ Hits 79367 79376 +9 + Misses 407635 407622 -13 - Partials 8860 8864 +4 
FlagCoverage Δ
uitests4.00% <ø> (ø)
unittests16.84% <ø> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12660

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@bernardodemarcobernardodemarco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@Pearl1594Pearl1594 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-12576)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53119 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10501-t12576-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

TestResultTime (s)Test File

@shwstppr

Copy link
Copy Markdown
ContributorAuthor

Test looks good now

[SF] Trillian test result (tid-12576) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 53119 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10501-t12576-kvm-ol8.zip Smoke tests completed. 141 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:
Test Result Time (s) Test File

@shwstppr
shwstppr merged commit 35a7438 into apache:4.20Mar 6, 2025
@shwstppr
shwstppr deleted the fix-purgebg-test branch March 6, 2025 03:55
@Pearl1594Pearl1594 moved this to Done in ACS 4.20.1Mar 17, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
…e#10501)
Failures seen in apache#10006 (comment) and others.
With apache#9773, the response of
listManagementServers API has been changed. serviceip has been renamed
to ipaddress. This was causing not all MS getting restarted and purge
b/g task not being able to run. The code handling API response in the
test has been updated.
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:integration-testPythonWarning... Python code Ahead!

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants

@shwstppr@blueorangutan@DaanHoogland@yadvr@Pearl1594@abh1sar@bernardodemarco