Fix to propagate updated management servers list and lb algorithm in host and indirect.agent.lb.algorithm settings resp, to systemvm agents by sureshanaparti · Pull Request #10524 · apache/cloudstack

sureshanaparti · 2025-03-07T09:25:34Z

Description

This PR fixes to propagate updated management servers list and lb algorithm in host and indirect.agent.lb.algorithm settings respectively, to systemvm agents.

Noticed updated management servers list is not propagated to the system VMs during testing, it's regression from #9840.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Updated management servers list and lb algorithm in host andd indirect.agent.lb.algorithm settings, and checked in the system vm configuration file (/usr/local/cloud/systemvm/conf/agent.properties).

How did you try to break this feature and the system with this change?

…d indirect.agent.lb.algorithm settings, to systemvm agents

sureshanaparti · 2025-03-07T09:26:38Z

@blueorangutan package

blueorangutan · 2025-03-07T09:28:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2025-03-07T09:33:14Z

Codecov Report

Attention: Patch coverage is 4.16667% with 23 lines in your changes missing coverage. Please review.

Project coverage is 16.00%. Comparing base (8b09295) to head (7cdfaa9).
Report is 13 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...loudstack/agent/lb/IndirectAgentLBServiceImpl.java	4.16%	23 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## 4.20 #10524 +/- ##
============================================
+ Coverage 4.00% 16.00% +12.00% - Complexity 0 13104 +13104 
============================================
Files 397 5651 +5254 Lines 32487 495858 +463371 Branches 5760 60046 +54286 ============================================
+ Hits 1301 79371 +78070 - Misses 31037 407627 +376590 - Partials 149 8860 +8711

Flag	Coverage Δ
uitests	`4.00% <ø> (ø)`
unittests	`16.84% <4.16%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2025-03-07T10:32:33Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 12698

sureshanaparti · 2025-03-07T13:17:45Z

@blueorangutan package

blueorangutan · 2025-03-07T13:20:06Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-03-07T14:35:41Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12704

DaanHoogland · 2025-03-09T19:28:00Z

@blueorangutan test matrix

blueorangutan · 2025-03-09T19:30:03Z

@DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

blueorangutan · 2025-03-09T19:38:30Z

[SF] Trillian Build Failed (tid-12626)

blueorangutan · 2025-03-09T20:10:34Z

[SF] Trillian Build Failed (tid-12625)

shwstppr

@sureshanaparti thanks for the fix. Left a couple of comments

sureshanaparti · 2025-03-10T09:21:09Z

@blueorangutan package

shwstppr

code lgtm

shwstppr · 2025-03-10T11:27:41Z

@blueorangutan package

blueorangutan · 2025-03-10T11:30:03Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-03-10T12:38:39Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12722

DaanHoogland · 2025-03-10T13:00:23Z

@blueorangutan test

blueorangutan · 2025-03-10T13:02:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-03-10T14:28:15Z

[SF] Trillian test result (tid-12627)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 65954 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10524-t12627-vmware-70u3.zip
Smoke tests completed. 136 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	`Error`	343.95	test_events_resource.py
test_01_events_resource	`Error`	343.96	test_events_resource.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	`Error`	117.37	test_network_permissions.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	`Error`	1524.84	test_network.py
test_02_restore_vm_with_disk_offering	`Error`	58.30	test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size	`Error`	58.31	test_restore_vm.py
test_02_restore_vm_strict_tags_failure	`Error`	61.62	test_vm_strict_host_tags.py

Pearl1594 · 2025-03-10T15:40:24Z

@blueorangutan package

blueorangutan · 2025-03-10T15:42:03Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-03-10T16:47:10Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12728

blueorangutan · 2025-03-10T18:05:07Z

[SF] Trillian test result (tid-12628)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9
Total time taken: 79447 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10524-t12628-xcpng82.zip
Smoke tests completed. 136 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_condensed_drs_algorithm	`Failure`	170.22	test_cluster_drs.py
test_02_balanced_drs_algorithm	`Failure`	177.34	test_cluster_drs.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	`Error`	30.06	test_network.py
test_01_non_strict_host_anti_affinity	`Error`	236.47	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	`Error`	122.58	test_nonstrict_affinity_group.py
test_02_create_volume	`Error`	2.21	test_resource_names.py
test_05_scale_vm_dont_allow_disk_offering_change	`Failure`	72.73	test_scale_vm.py

blueorangutan · 2025-03-11T05:39:13Z

[SF] Trillian test result (tid-12636)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 57012 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10524-t12636-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	`Error`	1519.45	test_network.py

DaanHoogland

clgtm

kiranchavala

LGTM, tested manually

Create a cloudstack environment
Login to the ssvm, cpvm and check the agent.properties

root@s-1-VM:~# cat /usr/local/cloud/systemvm/conf/agent.properties |grep host
host=10.0.35.136@static

Update the global setting configuration of value "host"= 10.0.35.136,10.0.35.137
Check agent.properties, found that the host value is propagated to the systemvm's

root@s-1-VM:~# cat /usr/local/cloud/systemvm/conf/agent.properties |grep host
host=10.0.35.136,10.0.35.137@static

yadvr · 2025-03-17T12:30:37Z

@blueorangutan package

blueorangutan · 2025-03-17T12:32:03Z

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-03-17T13:58:18Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12809

yadvr · 2025-03-18T03:23:33Z

@blueorangutan test

blueorangutan · 2025-03-18T03:24:03Z

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-03-18T18:55:27Z

[SF] Trillian test result (tid-12743)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53306 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10524-t12743-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

…host and indirect.agent.lb.algorithm settings resp, to systemvm agents (apache#10524) * propagate updated management servers list and lb algorithm in host and indirect.agent.lb.algorithm settings, to systemvm agents * addressed comments * addressed comments

propagate updated management servers list and lb algorithm in host an…
ded089a
…d indirect.agent.lb.algorithm settings, to systemvm agents

sureshanaparti requested review from shwstppr and weizhouapache March 7, 2025 09:25

sureshanaparti added this to the 4.20.1 milestone Mar 7, 2025

sureshanaparti requested a review from kiranchavala March 7, 2025 09:26

sureshanaparti marked this pull request as ready for review March 7, 2025 09:29

DaanHoogland added the type:regression label Mar 7, 2025

shwstppr reviewed Mar 10, 2025
View reviewed changes

Comment threadserver/src/main/java/org/apache/cloudstack/agent/lb/IndirectAgentLBServiceImpl.java Outdated
Comment threadserver/src/main/java/org/apache/cloudstack/agent/lb/IndirectAgentLBServiceImpl.java Outdated

addressed comments
67ae519

sureshanaparti requested a review from shwstppr March 10, 2025 09:21

shwstppr reviewed Mar 10, 2025
View reviewed changes

Comment threadserver/src/main/java/org/apache/cloudstack/agent/lb/IndirectAgentLBServiceImpl.java Outdated

shwstppr reviewed Mar 10, 2025
View reviewed changes

sureshanaparti requested a review from shwstppr March 10, 2025 11:02

shwstppr approved these changes Mar 10, 2025
View reviewed changes

DaanHoogland approved these changes Mar 11, 2025
View reviewed changes

addressed comments
7cdfaa9

sureshanaparti force-pushed the propagate-ms-list-to-systemvms branch from c6c21ac to 7cdfaa9Compare March 11, 2025 16:04

kiranchavala approved these changes Mar 17, 2025
View reviewed changes

Pearl1594 added this to ACS 4.20.1 Mar 17, 2025

Pearl1594 moved this to In Progress in ACS 4.20.1 Mar 17, 2025

Pearl1594 merged commit 33cdddf into apache:4.20Mar 18, 2025

github-project-automationBot moved this from In Progress to Done in ACS 4.20.1 Mar 18, 2025

Pearl1594 deleted the propagate-ms-list-to-systemvms branch March 18, 2025 18:58

Uh oh!

Conversation

sureshanaparti commented Mar 7, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

sureshanaparti commented Mar 7, 2025

Uh oh!

blueorangutan commented Mar 7, 2025

Uh oh!

codecovBot commented Mar 7, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Mar 7, 2025

Uh oh!

sureshanaparti commented Mar 7, 2025

Uh oh!

blueorangutan commented Mar 7, 2025

Uh oh!

blueorangutan commented Mar 7, 2025

Uh oh!

DaanHoogland commented Mar 9, 2025

Uh oh!

blueorangutan commented Mar 9, 2025

Uh oh!

blueorangutan commented Mar 9, 2025

Uh oh!

blueorangutan commented Mar 9, 2025

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sureshanaparti commented Mar 10, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Mar 10, 2025

Uh oh!

blueorangutan commented Mar 10, 2025

Uh oh!

blueorangutan commented Mar 10, 2025

Uh oh!

DaanHoogland commented Mar 10, 2025

Uh oh!

blueorangutan commented Mar 10, 2025

Uh oh!

blueorangutan commented Mar 10, 2025

Uh oh!

Pearl1594 commented Mar 10, 2025

Uh oh!

blueorangutan commented Mar 10, 2025

Uh oh!

blueorangutan commented Mar 10, 2025

Uh oh!

blueorangutan commented Mar 10, 2025

Uh oh!

blueorangutan commented Mar 11, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Mar 7, 2025•
edited
Loading

codecovBot commented Mar 7, 2025•
edited
Loading