UI: Restore AS Numbers and IPv4 Subnets menus by nvazquez · Pull Request #10580 · apache/cloudstack

nvazquez · 2025-03-17T15:33:29Z

Description

This PR fixes a regression on the UI in which the AS Numbers menu tab was removed, caused by the merge commit: 34d2a3b (check network.js file diff)

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Before:

After:

How did you try to break this feature and the system with this change?

nvazquez · 2025-03-17T15:54:13Z

@blueorangutan ui

blueorangutan · 2025-03-17T15:55:04Z

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

codecov · 2025-03-17T15:55:54Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.01%. Comparing base (f8adedc) to head (34c525a).
Report is 27 commits behind head on 4.20.

Additional details and impacted files

@@ Coverage Diff @@## 4.20 #10580 +/- ##
=========================================
Coverage 16.00% 16.01% - Complexity 13104 13115 +11 
=========================================
Files 5651 5651 Lines 495843 495881 +38 Branches 60045 60048 +3 =========================================
+ Hits 79363 79410 +47 + Misses 407624 407608 -16 - Partials 8856 8863 +7

Flag	Coverage Δ
uitests	`4.00% <ø> (-0.01%)`	⬇️
unittests	`16.85% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

weizhouapache

code lgtm

blueorangutan · 2025-03-17T16:13:18Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10580 (QA-JID-577)

Pearl1594

LGTM.

vishesh92 · 2025-03-17T17:09:26Z

I think we need to add some more changes back from the 34d2a3b. Specifically around guest network's details, bgp.peer, rotuing.firewall tab, etc.

… networks

nvazquez · 2025-03-17T21:47:29Z

Thanks @vishesh92 I have addressed that on the last commit, can you please re-review?

nvazquez · 2025-03-18T00:06:27Z

@blueorangutan ui

blueorangutan · 2025-03-18T00:07:04Z

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-03-18T00:26:31Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10580 (QA-JID-578)

Pearl1594 · 2025-03-25T13:17:30Z

@vishesh92 is your concern addressed?

vishesh92 · 2025-03-28T04:27:12Z

@nvazquez can you also revert this change

RosiKyu · 2025-04-02T10:41:42Z

@blueorangutan test keepEnv

blueorangutan · 2025-04-02T10:44:03Z

@rosi-shapeblue a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

nvazquez · 2025-04-08T11:38:47Z

Thanks @vishesh92 - I have addressed your last comments, can you please re-review?

@blueorangutan package

blueorangutan · 2025-04-08T11:40:04Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-04-08T13:04:52Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12981

vishesh92

clgtm

DaanHoogland · 2025-04-09T10:52:55Z

@blueorangutan ui

blueorangutan · 2025-04-09T10:54:04Z

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-04-09T11:12:10Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10580 (QA-JID-594)

DaanHoogland · 2025-04-10T10:46:52Z

I am not sure why, this works in a 4.20.1 lab env but not against qa, something is incompatible between the new UI and the old API , I think. I also think this is good for merge.
cc @nvazquez @Pearl1594

weizhouapache · 2025-04-10T11:02:29Z

I am not sure why, this works in a 4.20.1 lab env but not against qa, something is incompatible between the new UI and the old API , I think. I also think this is good for merge. cc @nvazquez @Pearl1594

it might be better to have QAs for at least 3 ACS versions

dev (main)
stable (4.20)
previous-stable lts (4.19)

nvazquez · 2025-04-11T10:21:22Z

Hi guys, I've done dev testing for 4.20 and main branches as both were affected and this PR fixed it. Will double check 4.19

nvazquez · 2025-04-11T10:32:33Z

@weizhouapache @DaanHoogland @Pearl1594 4.19 is not affected as the feature that introduced AS Numbers and IPv4 Subnets sections was introduced on 4.20 (#9470)

weizhouapache · 2025-04-11T12:27:09Z

thanks @nvazquez

verified locally

left panel

tab of routed network

details of routed network

* UI: Restore AS Numbers menu * Restore IPv4 Subnets menu * Add missing details for network and VPC details and tabs for Isolated networks * Address latest review comments

nvazquez requested review from DaanHoogland, Pearl1594, kiranchavala, vishesh92, weizhouapache and yadvr March 17, 2025 15:33

boring-cyborgBot added the component:UI label Mar 17, 2025

UI: Restore AS Numbers menu
84a2b04

nvazquez force-pushed the ui-fix-as-numbers branch from 4d2b0c2 to 84a2b04Compare March 17, 2025 15:40

nvazquez changed the base branch from main to 4.20March 17, 2025 15:41

Restore IPv4 Subnets menu
7dac8bb

nvazquez changed the title ~~UI: Restore AS Numbers menu~~UI: Restore AS Numbers and IPv4 Subnets menusMar 17, 2025

weizhouapache approved these changes Mar 17, 2025
View reviewed changes

Pearl1594 added this to ACS 4.20.1 Mar 17, 2025

Pearl1594 moved this to In Progress in ACS 4.20.1 Mar 17, 2025

Pearl1594 approved these changes Mar 17, 2025
View reviewed changes

Add missing details for network and VPC details and tabs for Isolated…
6792319
… networks

yadvr added this to the 4.20.1 milestone Mar 18, 2025

vishesh92 reviewed Mar 28, 2025
View reviewed changes

Comment threadui/src/config/section/network.js Outdated

Address latest review comments
34c525a

vishesh92 approved these changes Apr 9, 2025
View reviewed changes

weizhouapache merged commit d1df418 into apache:4.20Apr 11, 2025

github-project-automationBot moved this from In Progress to Done in ACS 4.20.1 Apr 11, 2025

Pearl1594 deleted the ui-fix-as-numbers branch April 11, 2025 12:58

Uh oh!

Conversation

nvazquez commented Mar 17, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

nvazquez commented Mar 17, 2025

Uh oh!

blueorangutan commented Mar 17, 2025

Uh oh!

codecovBot commented Mar 17, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Mar 17, 2025

Uh oh!

Pearl1594 left a comment

Choose a reason for hiding this comment

Uh oh!

vishesh92 commented Mar 17, 2025

Uh oh!

nvazquez commented Mar 17, 2025

Uh oh!

nvazquez commented Mar 18, 2025

Uh oh!

blueorangutan commented Mar 18, 2025

Uh oh!

blueorangutan commented Mar 18, 2025

Uh oh!

Pearl1594 commented Mar 25, 2025

Uh oh!

Uh oh!

vishesh92 commented Mar 28, 2025

Uh oh!

RosiKyu commented Apr 2, 2025

Uh oh!

blueorangutan commented Apr 2, 2025

Uh oh!

nvazquez commented Apr 8, 2025

Uh oh!

blueorangutan commented Apr 8, 2025

Uh oh!

blueorangutan commented Apr 8, 2025

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Apr 9, 2025

Uh oh!

blueorangutan commented Apr 9, 2025

Uh oh!

blueorangutan commented Apr 9, 2025

Uh oh!

DaanHoogland commented Apr 10, 2025

Uh oh!

weizhouapache commented Apr 10, 2025

Uh oh!

nvazquez commented Apr 11, 2025

Uh oh!

nvazquez commented Apr 11, 2025

Uh oh!

weizhouapache commented Apr 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

nvazquez commented Mar 17, 2025•
edited
Loading

codecovBot commented Mar 17, 2025•
edited
Loading