Support XenServer 8.4 / XCP 8.3 - make scripts python3 compatible

[Pearl1594]

Description

This PR is just to test #10483

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[Pearl1594]

@blueorangutan package

[blueorangutan]

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 203 lines in your changes missing coverage. Please review.

Project coverage is 16.12%. Comparing base (c1923a2) to head (0c8a738).
Report is 23 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
.../main/java/com/xensource/xenapi/ConnectionNew.java	0.00%	156 Missing ⚠️
...rce/wrapper/xenbase/CitrixStartCommandWrapper.java	0.00%	18 Missing ⚠️
...cloudstack/storage/template/UploadManagerImpl.java	0.00%	10 Missing ⚠️
...isor/xenserver/discoverer/XcpServerDiscoverer.java	0.00%	4 Missing ⚠️
...ervisor/xenserver/resource/CitrixResourceBase.java	0.00%	4 Missing ⚠️
...rvisor/xenserver/resource/XcpServer83Resource.java	0.00%	4 Missing ⚠️
...rvisor/xenserver/resource/Xenserver84Resource.java	0.00%	4 Missing ⚠️
...or/xenserver/resource/XenServerConnectionPool.java	0.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## 4.20 #10684 +/- ##
============================================
- Coverage 16.13% 16.12% -0.01% - Complexity 13219 13220 +1 
============================================
Files 5651 5654 +3 Lines 496740 496988 +248 Branches 60183 60238 +55 ============================================
+ Hits 80136 80154 +18 - Misses 407680 407910 +230 
Partials 8924 8924 

Flag	Coverage Δ
uitests	4.00% <ø> (-0.01%)	⬇️
unittests	16.97% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12999

[weizhouapache]

@blueorangutan test ol8 xenserver-84 keepEnv

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + xenserver-84) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-12931)

[DaanHoogland]

lint issues

[yadvr]

Good to see this, @Pearl1594 can we also add support for XCP-ng 8.3 (& related files as needed)? cc @weizhouapache@harikrishna-patnala

[Pearl1594]

yes @rohityadavcloud . Working with @harikrishna-patnala towards that.

[Pearl1594]

@blueorangutan package

[blueorangutan]

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + xcpng83) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-13206)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 56594 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10684-t13206-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[blueorangutan]

[SF] Trillian test result (tid-13207)
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 61798 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10684-t13207-kvm-ubuntu22.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_oobm_multiple_mgmt_server_ownership	Failure	30.88	test_outofbandmanagement.py
test_02_list_cpvm_vm	Failure	0.04	test_ssvm.py
test_04_cpvm_internals	Failure	0.05	test_ssvm.py

[blueorangutan]

[SF] Trillian test result (tid-13208)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 67120 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10684-t13208-vmware-70u3.zip
Smoke tests completed. 138 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_deployVMInSharedNetwork	Error	181.12	test_network.py
test_02_restore_vm_with_disk_offering	Error	63.66	test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size	Error	59.47	test_restore_vm.py
test_02_restore_vm_strict_tags_failure	Error	55.85	test_vm_strict_host_tags.py

[blueorangutan]

[SF] Trillian test result (tid-13210)
Environment: xenserver-84 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 67815 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10684-t13210-xenserver-84.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	Error	7.50	test_network.py

[blueorangutan]

[SF] Trillian test result (tid-13211)
Environment: xcpng83 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 74220 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10684-t13211-xcpng83.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	Error	7.55	test_network.py

[blueorangutan]

[SF] Trillian test result (tid-13209)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9
Total time taken: 82436 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10684-t13209-xcpng82.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	Error	10.60	test_network.py
test_10_list_volumes	Failure	371.05	test_volumes.py

[Pearl1594]

@blueorangutan package

[blueorangutan]

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13297

[yadvr]

@blueorangutan test ol8 xcpng83

[blueorangutan]

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + xcpng83) has been kicked to run smoke tests

[harikrishna-patnala]

changes LGTM

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)
C Maintainability Rating on New Code (required ≥ B)
C Reliability Rating on New Code (required ≥ B)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[blueorangutan]

[SF] Trillian test result (tid-13242)
Environment: xcpng83 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 75161 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10684-t13242-xcpng83.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	Error	1532.02	test_network.py

[kiranchavala]

LGTM, Tested with Xenserver 8.4 and XCPng 8.3

Test Case Execution	Result
Start a VM from a template	Pass
Remove/add an xenserver 8.4 and xcpng 8.3 host	Pass
Volume snapshots	Pass
Move a running VM to another host	Pass
Create / restore VM snapshot	Pass
Register ISO image and create a VM from it.	Pass
Standard VM operations – start/stop/reboot	Pass
Remove / add primary storage	Pass
check the console of vm's	Pass
Check the volume operations on a vm	Pass
Check the guest os catagories and mappings	Pass

[blueorangutan]

[SF] Trillian Build Failed (tid-13286)