Skip to content

Fix issue with Assign VM operation #10845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pearl1594 wants to merge 9 commits into from
Closed

Fix issue with Assign VM operation #10845

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
23482e4
Fix issue with Assign VM operation
Pearl1594 May 8, 2025
646ccd8
fix assign vm issue
Pearl1594 May 9, 2025
4cb5198
fix test and variable name
Pearl1594 May 12, 2025
277fee1
use AtomicBoolean
Pearl1594 May 12, 2025
1d46506
Merge branch '4.20' of https://github.com/apache/cloudstack into fix-…
Pearl1594 May 12, 2025
caa8c81
move change ownership logic
Pearl1594 May 12, 2025
fd7159c
rearrange logic for change of ownership to avoid any resources being …
Pearl1594 May 13, 2025
8fbe8b4
Merge branch '4.20' of https://github.com/apache/cloudstack into fix-…
Pearl1594 May 13, 2025
49b76c9
revert changes made
Pearl1594 May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7445,12 +7445,7 @@ public UserVm moveVmToUser(final AssignVMCmd cmd) throws ResourceAllocationExcep
logger.trace("Verifying if the new account [{}] has access to the specified domain [{}].", newAccount, domain);
_accountMgr.checkAccess(newAccount, domain);

Transaction.execute(new TransactionCallbackNoReturn() {
@Override
public void doInTransactionWithoutResult(TransactionStatus status) {
executeStepsToChangeOwnershipOfVm(cmd, caller, oldAccount, newAccount, vm, offering, volumes, template, domainId);
}
});
executeStepsToChangeOwnershipOfVm(cmd, caller, oldAccount, newAccount, vm, offering, volumes, template, domainId);

logger.info("VM [{}] now belongs to account [{}].", vm.getInstanceName(), newAccountName);
return vm;
Expand DownExpand Up@@ -7944,7 +7939,8 @@ protected NetworkVO addNicsToApplicableNetworksAndReturnDefaultNetwork(LinkedHas
* @throws InsufficientCapacityException
* @throws ResourceAllocationException
*/
protected void selectApplicableNetworkToCreateVm(Account caller, Account newAccount, DataCenterVO zone, Set<NetworkVO> applicableNetworks)
protected void selectApplicableNetworkToCreateVm(Account caller, Account newAccount, DataCenterVO zone,
Set<NetworkVO> applicableNetworks)
throws InsufficientCapacityException, ResourceAllocationException {

logger.trace("Selecting the applicable network to create the VM.");
Expand Down