[VMware to KVM Migration] Fix for converted instance NPE issue when source VMware instance OVF is exported from management server

[sureshanaparti]

Description

This PR fixes converted instance NPE issue in VMware to KVM Migration when source VMware instance OVF is exported from management server.

Fixes#10982

Some of the changes of the below PRs were missing in 4.20, resulting in NPE.

• Allow VMWare import via another host #9787
• check tags while fetching storage pool for importing vm #9764
• VMware import issue fix - check and update pools in the order of disks #10409

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested VMware instance migration to KVM, without ovftool installation on KVM hosts. OVF of source VMware instance is downloaded from Management Server.

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 16.15%. Comparing base (0b841fe) to head (6b1a220).
Report is 17 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
.../wrapper/LibvirtConvertInstanceCommandWrapper.java	50.00%	3 Missing ⚠️
.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java	33.33%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## 4.20 #11003 +/- ##
==========================================
Coverage 16.14% 16.15% - Complexity 13256 13266 +10 
==========================================
Files 5657 5657 Lines 497903 497701 -202 Branches 60375 60349 -26 ==========================================
- Hits 80392 80388 -4 + Misses 408550 408369 -181 + Partials 8961 8944 -17 

Flag	Coverage Δ
uitests	4.00% <ø> (ø)
unittests	17.00% <44.44%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13706

[DaanHoogland]

One very nitpicking comment.

Is this ready for review yet @sureshanaparti ?

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13749

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-13540)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 56279 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11003-t13540-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_isolate_network_FW_PF_default_routes_egress_true	Failure	114.48	test_routers_network_ops.py

[DaanHoogland]

clgtm

[borisstoyanov]

LGTM, I didn't encounter any issues while testing it

[sureshanaparti]

Merging based on the review/tests.