UI support for deploy a VM from volume/snapshot by slavkap · Pull Request #11164 · apache/cloudstack

slavkap · 2025-07-08T10:17:01Z

Description

This PR adds a UI option to deploy a virtual machine with an existing volume or a disk snapshot

These changes depend on #10503

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale

Major
Minor

Screenshots (if appropriate):

The users will have the option to choose how to deploy a new virtual machine - Template/ISO/Volume/Snapshot

How Has This Been Tested?

manual tests

codecov · 2025-07-08T10:24:44Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.34%. Comparing base (76cfcb4) to head (d326104).
⚠️ Report is 64 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #11164 +/- ##
============================================
+ Coverage 17.17% 17.34% +0.17% - Complexity 14993 15186 +193 
============================================
Files 5869 5883 +14 Lines 521728 524501 +2773 Branches 63506 64003 +497 ============================================
+ Hits 89604 90999 +1395 - Misses 422053 423219 +1166 - Partials 10071 10283 +212

Flag	Coverage Δ
uitests	`3.63% <ø> (-0.13%)`	⬇️
unittests	`18.38% <ø> (+0.23%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sureshanaparti · 2025-07-14T09:41:52Z

@blueorangutan package

blueorangutan · 2025-07-14T09:44:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-14T12:06:09Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14162

sureshanaparti · 2025-07-26T08:16:36Z

@blueorangutan package

blueorangutan · 2025-07-26T08:18:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sureshanaparti · 2025-07-26T08:18:43Z

@blueorangutan ui

blueorangutan · 2025-07-26T08:20:04Z

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copilot

Pull Request Overview

This PR adds UI functionality to deploy virtual machines from existing volumes and disk snapshots, expanding beyond the existing template and ISO options.

Key changes:

Added volume and snapshot radio button options in the image selection UI
Implemented volume and snapshot fetching logic with filtering for unattached volumes and root snapshots
Added form handling and validation for volume and snapshot deployment parameters

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
ui/src/views/compute/wizard/OsBasedImageSelection.vue	Added radio buttons for volume and snapshot selection options
ui/src/views/compute/DeployVM.vue	Core implementation including form fields, data fetching, validation, and deployment logic for volumes and snapshots
ui/public/locales/en.json	Added localization strings for volume and snapshot descriptions

sureshanaparti · 2025-07-26T08:28:59Z

@slavkap can you check the Copilot comments, are they relevant?

blueorangutan · 2025-07-26T08:37:21Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11164 (QA-JID-691)

blueorangutan · 2025-07-26T10:11:34Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 14389

sureshanaparti · 2025-07-26T12:10:16Z

@blueorangutan package

blueorangutan · 2025-07-26T12:12:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-26T13:23:23Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14396

sureshanaparti · 2025-07-28T09:06:45Z

@blueorangutan package

blueorangutan · 2025-07-28T09:08:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-28T10:32:00Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 14416

slavkap · 2025-07-28T11:30:14Z

@blueorangutan package

blueorangutan · 2025-07-28T11:32:07Z

@slavkap a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sureshanaparti · 2025-07-29T07:24:16Z

@slavkap The volume & snapshots shown in deployment form are not relevant to the category. Volumes are not listed, checked in env with some ROOT & DATA volumes, also uploaded volumes. Can you please check.

Instance from Volume

Instance from Snapshot

RosiKyu

LGTM. I have tested both FE and BE functionalities. It is possible to deploy an Instance from volume as well as from snapshot. The volumes/snapshots are displayed in the Instance creation form.

DaanHoogland

clgtm

github-actions · 2025-07-29T15:13:00Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

sureshanaparti · 2025-07-30T05:07:52Z

@slavkap can you check the conflicts

ui support to deploy a virtual machine with existing volume or a disk snapshot

Removed OS/User options when using volume/snapshot refactoring

slavkap · 2025-07-30T13:05:07Z

@slavkap The volume & snapshots shown in deployment form are not relevant to the category. Volumes are not listed, checked in env with some ROOT & DATA volumes, also uploaded volumes. Can you please check.
* Instance from Volume
* Instance from Snapshot

@sureshanaparti, I have removed the option to choose OS/user because those aren't used with the snapshot/volume option

slavkap · 2025-07-30T13:06:53Z

@blueorangutan package

blueorangutan · 2025-07-30T13:08:04Z

@slavkap a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-30T14:39:52Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14473

sureshanaparti · 2025-07-31T09:00:10Z

LGTM, able to create instance

from a detached volume (a ROOT volume, or a volume created from ROOT volume's snapshot in Zone-wide pool and having valid template details. Otherwise, it fails with "The provided volume/snapshot doesn't have a template to deploy a VM").
from snapshot (of a ROOT volume).

UI listed only detached volumes in Ready state, and snapshots of ROOT volumes. Volumes in Zone-wide pools are only supported for instance creation. Otherwise, it fails with "Deployment of virtual machine is supported only for Zone-wide storage pools".

@slavkap The parameters - oscategoryid, volumefilter, details, isvnf, showicon are not applicable while listing volumes, and oscategoryid, snapshotfilter, details, isvnf, showicon are not applicable while listing snapshots. Also, listOsCategories is called before listVolumes and listSnapshots, which is not required. Can you check this.

removed unnecessary API params

sureshanaparti · 2025-07-31T12:46:10Z

@blueorangutan ui

blueorangutan · 2025-07-31T12:48:05Z

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-07-31T13:05:42Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11164 (QA-JID-711)

removed invoking of listOsCategories when listing volumes or snapshots

sureshanaparti · 2025-07-31T13:29:10Z

Verified the list volumes and snapshots calls locally, these parameters are removed. Also, listOsCategories is not called. Thanks @slavkap

* UI support for deploy a virtual machine with existing volume or a disk snapshot

boring-cyborgBot added the component:UI label Jul 8, 2025

sureshanaparti added this to the 4.21.0 milestone Jul 14, 2025

sureshanaparti added this to Apache CloudStack 4.21.0 Jul 14, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.21.0 Jul 14, 2025

sureshanaparti mentioned this pull request Jul 14, 2025
Deploy VM from Snapshot #4492
Closed

sureshanaparti added the status:needs-testing label Jul 14, 2025

RosiKyu self-assigned this Jul 22, 2025

sureshanaparti requested a review from vishesh92 July 26, 2025 08:13

vishesh92 requested a review from Copilot July 26, 2025 08:22

CopilotAI reviewed Jul 26, 2025
View reviewed changes

Comment threadui/src/views/compute/DeployVM.vue Outdated
Comment threadui/src/views/compute/DeployVM.vue Outdated
Comment threadui/src/views/compute/DeployVM.vue Outdated

slavkap force-pushed the ui-deploy-vm-from-volume-or-snapshot branch from 07c5d50 to 693539dCompare July 28, 2025 11:29

sureshanaparti requested review from Pearl1594 and shwstppr July 28, 2025 14:45

RosiKyu approved these changes Jul 29, 2025
View reviewed changes

RosiKyu removed the status:needs-testing label Jul 29, 2025

DaanHoogland approved these changes Jul 29, 2025
View reviewed changes

Comment threadui/src/views/compute/DeployVM.vue Outdated

github-actionsBot added the status:has-conflicts label Jul 29, 2025

slavkap added 3 commits July 30, 2025 08:57

UI support for deploy VM fro volume/snapshot
ee01c9b
ui support to deploy a virtual machine with existing volume or a disk snapshot

fix pages
13b1796

Addressed reviews
ca09591
Removed OS/User options when using volume/snapshot refactoring

slavkap force-pushed the ui-deploy-vm-from-volume-or-snapshot branch from 693539d to ca09591Compare July 30, 2025 13:03

github-actionsBot removed the status:has-conflicts label Jul 30, 2025

addressed reviews
b89d2a7
removed unnecessary API params

addressed comments
d326104
removed invoking of listOsCategories when listing volumes or snapshots

sureshanaparti merged commit adccdf2 into apache:mainJul 31, 2025
24 of 26 checks passed

github-project-automationBot moved this from In Progress to Done in Apache CloudStack 4.21.0 Jul 31, 2025

slavkap deleted the ui-deploy-vm-from-volume-or-snapshot branch July 31, 2025 15:23

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 6, 2025
UI support for deploy a VM from volume/snapshot (apache#11164)
dd60131
* UI support for deploy a virtual machine with existing volume or a disk snapshot

sureshanaparti added the type:improvement label Aug 8, 2025

Uh oh!

Conversation

slavkap commented Jul 8, 2025• edited by sureshanaparti Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

codecovBot commented Jul 8, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sureshanaparti commented Jul 14, 2025

Uh oh!

blueorangutan commented Jul 14, 2025

Uh oh!

blueorangutan commented Jul 14, 2025

Uh oh!

sureshanaparti commented Jul 26, 2025

Uh oh!

blueorangutan commented Jul 26, 2025

Uh oh!

sureshanaparti commented Jul 26, 2025

Uh oh!

blueorangutan commented Jul 26, 2025

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sureshanaparti commented Jul 26, 2025

Uh oh!

blueorangutan commented Jul 26, 2025

Uh oh!

blueorangutan commented Jul 26, 2025

Uh oh!

sureshanaparti commented Jul 26, 2025

Uh oh!

blueorangutan commented Jul 26, 2025

Uh oh!

blueorangutan commented Jul 26, 2025

Uh oh!

sureshanaparti commented Jul 28, 2025

Uh oh!

blueorangutan commented Jul 28, 2025

Uh oh!

blueorangutan commented Jul 28, 2025

Uh oh!

slavkap commented Jul 28, 2025

Uh oh!

blueorangutan commented Jul 28, 2025

Uh oh!

sureshanaparti commented Jul 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RosiKyu left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actionsBot commented Jul 29, 2025

Uh oh!

sureshanaparti commented Jul 30, 2025

Uh oh!

slavkap commented Jul 30, 2025

Uh oh!

slavkap commented Jul 30, 2025

Uh oh!

blueorangutan commented Jul 30, 2025

Uh oh!

blueorangutan commented Jul 30, 2025

Uh oh!

slavkap commented Jul 8, 2025•
edited by sureshanaparti
Loading

codecovBot commented Jul 8, 2025•
edited
Loading

sureshanaparti commented Jul 29, 2025•
edited
Loading