server: add user.password.reset.smtp.useStartTLS and enabledSecurityProtocols for password reset by weizhouapache · Pull Request #11228 · apache/cloudstack

weizhouapache · 2025-07-17T01:29:58Z

Description

This PR fixes#11159

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2025-07-17T01:37:13Z

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.17%. Comparing base (0f0155c) to head (807dd9a).
⚠️ Report is 64 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
.../cloudstack/user/UserPasswordResetManagerImpl.java	0.00%	4 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## 4.20 #11228 +/- ##
=========================================
Coverage 16.17% 16.17% - Complexity 13283 13284 +1 
=========================================
Files 5656 5656 Lines 497996 498002 +6 Branches 60401 60401 =========================================
+ Hits 80533 80534 +1 - Misses 408500 408506 +6 + Partials 8963 8962 -1

Flag	Coverage Δ
uitests	`4.00% <ø> (ø)`
unittests	`17.02% <33.33%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland

clgtm

DaanHoogland · 2025-07-17T07:27:13Z

much more needed on this @weizhouapache ?

DaanHoogland · 2025-07-17T07:27:26Z

@blueorangutan package

blueorangutan · 2025-07-17T07:28:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

weizhouapache · 2025-07-17T07:54:49Z

much more needed on this @weizhouapache ?

@DaanHoogland
that's all, I think

blueorangutan · 2025-07-17T08:39:30Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14228

DaanHoogland · 2025-07-17T08:40:26Z

@blueorangutan test keepEnv

blueorangutan · 2025-07-17T08:42:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

… for password reset

weizhouapache · 2025-07-17T12:44:27Z

@blueorangutan package

blueorangutan · 2025-07-17T12:46:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-17T14:09:43Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14231

weizhouapache · 2025-07-17T14:10:55Z

@blueorangutan package

blueorangutan · 2025-07-17T14:12:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-17T15:44:17Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14234

blueorangutan · 2025-07-18T00:21:23Z

[SF] Trillian test result (tid-13810)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53543 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11228-t13810-kvm-ol8.zip
Smoke tests completed. 142 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

weizhouapache · 2025-07-18T02:54:58Z

@DaanHoogland
I added another configuration "user.password.reset.smtp.enabledSecurityProtocols"

DaanHoogland · 2025-07-18T07:28:58Z

@DaanHoogland I added another configuration "user.password.reset.smtp.enabledSecurityProtocols"

still looks good. ;) still needs testing though. ...

harikrishna-patnala · 2025-08-29T08:34:18Z

@weizhouapache also please check if this PR needs any branch or milestone changes

weizhouapache · 2025-08-29T08:48:35Z

thanks @harikrishna-patnala
changed the target branch to 4.20

sureshanaparti

clgtm

vishesh92

lgtm

vishesh92 · 2025-10-03T09:32:55Z

@blueorangutan package

blueorangutan · 2025-10-03T09:34:04Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-03T10:55:43Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15275

DaanHoogland · 2025-10-03T17:46:44Z

@blueorangutan test

blueorangutan · 2025-10-03T17:48:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-10-03T18:39:40Z

[SF] Trillian Build Failed (tid-14518)

blueorangutan · 2025-10-06T21:59:57Z

[SF] Trillian test result (tid-14530)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 54237 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11228-t14530-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_13_retrieve_vr_default_files	`Error`	1.12	test_diagnostics.py
test_14_retrieve_vr_one_file	`Error`	1.12	test_diagnostics.py
test_15_retrieve_ssvm_default_files	`Error`	1.12	test_diagnostics.py
test_16_retrieve_ssvm_single_file	`Error`	1.12	test_diagnostics.py
test_17_retrieve_cpvm_default_files	`Error`	1.12	test_diagnostics.py
test_18_retrieve_cpvm_single_file	`Error`	1.12	test_diagnostics.py

vishesh92

lgtm. tested with mailpit after enabling STARTTLS required.

…rotocols for password reset (apache#11228)

server: add user.password.reset.smtp.useStartTLS for password reset
675cd63

DaanHoogland approved these changes Jul 17, 2025
View reviewed changes

server: add missing user.password.reset.smtp.enabledSecurityProtocols…
368c511
… for password reset

DaanHoogland added this to Apache CloudStack 4.21.0 Jul 18, 2025

weizhouapache marked this pull request as ready for review August 5, 2025 03:15

DaanHoogland added the status:needs-testing label Aug 20, 2025

harikrishna-patnala reviewed Aug 29, 2025
View reviewed changes

Comment threadserver/src/main/java/org/apache/cloudstack/user/UserPasswordResetManager.java

weizhouapache changed the base branch from main to 4.20August 29, 2025 08:34

weizhouapache added 2 commits August 29, 2025 10:49

Merge branch '4.20' into 4.20-fix-password-reset-starttls
3f6d458

Update 11228
807dd9a

sureshanaparti removed this from Apache CloudStack 4.21.0 Aug 29, 2025

sureshanaparti added this to Apache CloudStack 4.22.0 Aug 29, 2025

sureshanaparti removed this from Apache CloudStack 4.22.0 Aug 29, 2025

sureshanaparti added this to the 4.20.2 milestone Aug 29, 2025

sureshanaparti approved these changes Aug 29, 2025
View reviewed changes

vishesh92 approved these changes Sep 8, 2025
View reviewed changes

weizhouapache changed the title ~~server: add user.password.reset.smtp.useStartTLS for password reset~~server: add user.password.reset.smtp.useStartTLS and enabledSecurityProtocols for password resetSep 12, 2025

vishesh92 approved these changes Oct 7, 2025
View reviewed changes

vishesh92 removed the status:needs-testing label Oct 7, 2025

vishesh92 merged commit 963a67b into apache:4.20Oct 7, 2025
26 checks passed

DaanHoogland deleted the 4.20-fix-password-reset-starttls branch October 7, 2025 06:27

weizhouapache mentioned this pull request Oct 7, 2025
CS 4.20.1 Password Reset Functionality Java Error #11159
Closed

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 17, 2025
server: add user.password.reset.smtp.useStartTLS and enabledSecurityP…
c32dad0
…rotocols for password reset (apache#11228)

sandeeplocharla pushed a commit to NetApp/cloudstack that referenced this pull request Oct 21, 2025
server: add user.password.reset.smtp.useStartTLS and enabledSecurityP…
9e46ee1
…rotocols for password reset (apache#11228)

Uh oh!

Conversation

weizhouapache commented Jul 17, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecovBot commented Jul 17, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jul 17, 2025

Uh oh!

DaanHoogland commented Jul 17, 2025

Uh oh!

blueorangutan commented Jul 17, 2025

Uh oh!

weizhouapache commented Jul 17, 2025

Uh oh!

blueorangutan commented Jul 17, 2025

Uh oh!

DaanHoogland commented Jul 17, 2025

Uh oh!

blueorangutan commented Jul 17, 2025

Uh oh!

weizhouapache commented Jul 17, 2025

Uh oh!

blueorangutan commented Jul 17, 2025

Uh oh!

blueorangutan commented Jul 17, 2025

Uh oh!

weizhouapache commented Jul 17, 2025

Uh oh!

blueorangutan commented Jul 17, 2025

Uh oh!

blueorangutan commented Jul 17, 2025

Uh oh!

blueorangutan commented Jul 18, 2025

Uh oh!

weizhouapache commented Jul 18, 2025

Uh oh!

DaanHoogland commented Jul 18, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

harikrishna-patnala commented Aug 29, 2025

Uh oh!

weizhouapache commented Aug 29, 2025

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

vishesh92 commented Oct 3, 2025

Uh oh!

blueorangutan commented Oct 3, 2025

Uh oh!

blueorangutan commented Oct 3, 2025

Uh oh!

DaanHoogland commented Oct 3, 2025

Uh oh!

blueorangutan commented Oct 3, 2025

Uh oh!

blueorangutan commented Oct 3, 2025

Uh oh!

blueorangutan commented Oct 6, 2025

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

codecovBot commented Jul 17, 2025•
edited
Loading

DaanHoogland commented Jul 18, 2025•
edited
Loading