Skip to content

ui: fix initial pagination for images in deploy forms - #11349

Merged
sureshanaparti merged 1 commit into
apache:mainfrom
shapeblue:fix-tmpllistinitialpagination
Aug 1, 2025
Merged

ui: fix initial pagination for images in deploy forms#11349
sureshanaparti merged 1 commit into
apache:mainfrom
shapeblue:fix-tmpllistinitialpagination

Conversation

@shwstppr

Copy link
Copy Markdown
Contributor

Description

Regression from #10773
All templates for a category are getting listed initially. This PR fixes by adding pagination correctly

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Regression from apache#10773
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov

codecovBot commented Jul 30, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.17%. Comparing base (76cfcb4) to head (fa79d0e).
⚠️ Report is 29 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #11349 +/- ##
=========================================
Coverage 17.17% 17.17% - Complexity 14993 14994 +1 
=========================================
Files 5869 5869 Lines 521728 521728 Branches 63506 63506 =========================================
+ Hits 89604 89606 +2 + Misses 422053 422052 -1 + Partials 10071 10070 -1 
FlagCoverage Δ
uitests3.76% <ø> (ø)
unittests18.15% <ø> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHooglandDaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11349 (QA-JID-705)

@sureshanapartisureshanaparti added this to the 4.21.0 milestone Aug 1, 2025
@sureshanaparti
sureshanaparti merged commit b2ce1fb into apache:mainAug 1, 2025
23 of 25 checks passed
@github-project-automationgithub-project-automationBot moved this from In Progress to Done in Apache CloudStack 4.21.0Aug 1, 2025
@sureshanaparti
sureshanaparti deleted the fix-tmpllistinitialpagination branch August 1, 2025 12:14
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 6, 2025
Regression from apache#10773
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants

@shwstppr@blueorangutan@yadvr@DaanHoogland@sureshanaparti