CKS: fix control plane endpoint IP

[weizhouapache]

Description

This PR fixes#11579

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.42%. Comparing base (ec533cd) to head (a327619).
⚠️ Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
...er/actionworkers/KubernetesClusterStartWorker.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #11720 +/- ##
=========================================
Coverage 17.42% 17.42% - Complexity 15336 15339 +3 
=========================================
Files 5892 5892 Lines 526521 526521 Branches 64293 64293 =========================================
+ Hits 91767 91772 +5 + Misses 424401 424393 -8 - Partials 10353 10356 +3 

Flag	Coverage Δ
uitests	3.61% <ø> (ø)
unittests	18.48% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15164

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[Pearl1594]

lgtm.
Seems like this chane got introduced in: #9102

[harikrishna-patnala]

code LGTM

[blueorangutan]

[SF] Trillian test result (tid-14438)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53886 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11720-t14438-kvm-ol8.zip
Smoke tests completed. 147 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[shwstppr]

LGTM. Tested with KVM env.

1. Without changes in 4.22 env, created k8s cluster with https://download.cloudstack.org/cks/setup-v1.33.1-calico-x86_64.iso
2. Tried using kubeconf

[root@qa1-4 ~]# ./kubectl --kubeconfig before.conf get nodes
E0929 06:53:43.728671 16427 memcache.go:265] "Unhandled Error" err="couldn't get current server API group list: Get \"https://172.120.1.3:6443/api?timeout=32s\": tls: failed to verify certificate: x509: certificate is valid for 10.96.0.1, 10.1.1.10, not 172.120.1.3"
E0929 06:53:43.735420 16427 memcache.go:265] "Unhandled Error" err="couldn't get current server API group list: Get \"https://172.120.1.3:6443/api?timeout=32s\": tls: failed to verify certificate: x509: certificate is valid for 10.96.0.1, 10.1.1.10, not 172.120.1.3"
E0929 06:53:43.741359 16427 memcache.go:265] "Unhandled Error" err="couldn't get current server API group list: Get \"https://172.120.1.3:6443/api?timeout=32s\": tls: failed to verify certificate: x509: certificate is valid for 10.96.0.1, 10.1.1.10, not 172.120.1.3"
E0929 06:53:43.748138 16427 memcache.go:265] "Unhandled Error" err="couldn't get current server API group list: Get \"https://172.120.1.3:6443/api?timeout=32s\": tls: failed to verify certificate: x509: certificate is valid for 10.96.0.1, 10.1.1.10, not 172.120.1.3"
E0929 06:53:43.753731 16427 memcache.go:265] "Unhandled Error" err="couldn't get current server API group list: Get \"https://172.120.1.3:6443/api?timeout=32s\": tls: failed to verify certificate: x509: certificate is valid for 10.96.0.1, 10.1.1.10, not 172.120.1.3"
Unable to connect to the server: tls: failed to verify certificate: x509: certificate is valid for 10.96.0.1, 10.1.1.10, not 172.120.1.3

3. Applied PR changes and deployed a new k8s cluster
4. Tried using new cluster's kubeconf

[root@qa1-4 ~]# ./kubectl --kubeconfig after.conf get nodes
NAME STATUS ROLES AGE VERSION
test-after-control-1999442df93 Ready control-plane 52s v1.33.1
test-after-node-199944316ec Ready <none> 41s v1.33.1

[weizhouapache]

thanks a lot @shwstppr for the testing

merging based on approvals and tests