Skip to content

UI: Fix primary storage for datastore cluster and retain traffic labels during zone deployment - #11760

Merged
DaanHoogland merged 3 commits into
apache:4.20from
shapeblue:preserveNetworkTag
Oct 8, 2025
Merged

UI: Fix primary storage for datastore cluster and retain traffic labels during zone deployment#11760
DaanHoogland merged 3 commits into
apache:4.20from
shapeblue:preserveNetworkTag

Conversation

@sudo87

@sudo87sudo87 commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

Description

This PR fixes#8567

  1. Primary storage creation for data store cluster in zone deployment
  2. Retaining label for traffic type

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

  1. By deploying Zone with data store cluster for Vmware
  2. Validated traffic label for kvm deployment

How did you try to break this feature and the system with this change?

@sudo87

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan uibuild

@blueorangutan

Copy link
Copy Markdown

@sudo87 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov

codecovBot commented Sep 30, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.17%. Comparing base (5dfeb79) to head (9fd28b5).
⚠️ Report is 13 commits behind head on 4.20.

Additional details and impacted files
@@ Coverage Diff @@## 4.20 #11760 +/- ##
============================================
- Coverage 16.17% 16.17% -0.01% + Complexity 13296 13295 -1 
============================================
Files 5656 5656 Lines 498223 498263 +40 Branches 60454 60465 +11 ============================================
+ Hits 80577 80582 +5 - Misses 408676 408711 +35 
Partials 8970 8970 
FlagCoverage Δ
uitests4.00% <ø> (-0.01%)⬇️
unittests17.02% <ø> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11760 (QA-JID-767)

@harikrishna-patnalaharikrishna-patnala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@sudo87sudo87 changed the title UI: retain traffic labels during zone deploymentUI: Fix primary storage for datastore cluster and retain traffic labels during zone deploymentOct 1, 2025
@sudo87

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan uibuild

@blueorangutan

Copy link
Copy Markdown

@sudo87 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11760 (QA-JID-771)

@nvazqueznvazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sudo87 - LGTM

@harikrishna-patnalaharikrishna-patnala added this to the 4.20.2 milestone Oct 2, 2025
@sudo87

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15270

@sudo87

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@sudo87 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Comment threadui/src/views/infra/zone/ZoneWizardPhysicalNetworkSetupStep.vue Outdated
@vishesh92

Copy link
Copy Markdown
Member

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11760 (QA-JID-774)

@vishesh92vishesh92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. tested and verified the fix for the traffic labels.

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-14546)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 54619 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11760-t14546-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

TestResultTime (s)Test File

@DaanHoogland
DaanHoogland merged commit 9f20979 into apache:4.20Oct 8, 2025
26 checks passed
@DaanHoogland
DaanHoogland deleted the preserveNetworkTag branch October 8, 2025 11:38
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 17, 2025
sandeeplocharla pushed a commit to NetApp/cloudstack that referenced this pull request Oct 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@sudo87@blueorangutan@vishesh92@harikrishna-patnala@nvazquez@DaanHoogland