systemvm: fix duplicated "en_US.UTF-8 UTF-8" in /etc/locale.gen by weizhouapache · Pull Request #11823 · apache/cloudstack

weizhouapache · 2025-10-10T12:02:21Z

Description

We faced some issues with systemvm template on VMware 80u3 in the past

GetDomRVersionAnswer":{"templateVersion":"Cloudstack Release 4.20.2 Mon Jul 28 10:05:08 AM UTC 2025","scriptsVersion":"9c19873be16a634b982a3838db1ee0d7
bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
","result":"true","details":"Cloudstack Release 4.20.2 Mon Jul 28 10:05:08 AM UTC 2025&9c19873be16a634b982a3838db1ee0d7
bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)

the issue is fixed by rebuilding the systemvm template

this issue appears again with last systemvm template for #11778

The issue seems to be caused by duplicated "en_US.UTF-8 UTF-8" in /etc/locale.gen

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache · 2025-10-10T12:03:08Z

@blueorangutan package

blueorangutan · 2025-10-10T12:04:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2025-10-10T12:10:06Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.17%. Comparing base (4d95f08) to head (144672c).
⚠️ Report is 4 commits behind head on 4.20.

Additional details and impacted files

@@ Coverage Diff @@## 4.20 #11823 +/- ##
=========================================
Coverage 16.17% 16.17% - Complexity 13297 13301 +4 
=========================================
Files 5656 5656 Lines 498331 498331 Branches 60476 60476 =========================================
+ Hits 80591 80602 +11 + Misses 408767 408754 -13 - Partials 8973 8975 +2

Flag	Coverage Δ
uitests	`4.00% <ø> (ø)`
unittests	`17.02% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2025-10-10T14:22:03Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15400

blueorangutan · 2025-10-10T20:31:49Z

[SF] Trillian Build Failed (tid-14628)

blueorangutan · 2025-10-11T14:12:22Z

[SF] Trillian test result (tid-14629)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 63082 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11823-t14629-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2025-10-11T15:53:19Z

[SF] Trillian test result (tid-14630)
Environment: kvm-ubuntu24 (x2), zone: Advanced Networking with Mgmt server u24
Total time taken: 64339 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11823-t14630-kvm-ubuntu24.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2025-10-11T18:42:00Z

[SF] Trillian test result (tid-14627)
Environment: vmware-80u3 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 79859 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11823-t14627-vmware-80u3.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_deploy_more_vms_than_limit_allows	`Error`	200.13	test_deploy_vms_in_parallel.py

blueorangutan · 2025-10-11T21:08:07Z

[SF] Trillian test result (tid-14626)
Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 89107 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11823-t14626-xcpng82.zip
Smoke tests completed. 138 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_enableHumanReadableLogs	`Error`	0.23	test_human_readable_logs.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	807.33	test_kubernetes_clusters.py
test_01_primary_storage_iscsi	`Error`	0.90	test_primary_storage.py

DaanHoogland

makes sense, are we sure “en_US.UTF-8 UTF-8” is always put on a new line in the cat statement? iirc yes, but my bash needs brushing up ;)

weizhouapache · 2025-10-13T09:50:26Z

makes sense, are we sure “en_US.UTF-8 UTF-8” is always put on a new line in the cat statement? iirc yes, but my bash needs brushing up ;)

yes, if we use cat >>

harikrishna-patnala

code LGTM

blueorangutan · 2025-10-13T10:06:14Z

[SF] Trillian test result (tid-14636)
Environment: vmware-80u3 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 80953 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11823-t14636-vmware-80u3.zip
Smoke tests completed. 138 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestClusterDRS>:setup	`Error`	0.00	test_cluster_drs.py
test_deploy_more_vms_than_limit_allows	`Error`	207.02	test_deploy_vms_in_parallel.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	3680.00	test_kubernetes_clusters.py

blueorangutan · 2025-10-13T10:14:32Z

[SF] Trillian test result (tid-14635)
Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 81811 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11823-t14635-xcpng82.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_primary_storage_iscsi	`Error`	0.85	test_primary_storage.py
test_02_list_cpvm_vm	`Failure`	0.04	test_ssvm.py
test_04_cpvm_internals	`Failure`	0.05	test_ssvm.py

weizhouapache · 2025-10-13T18:36:49Z

@blueorangutan package

blueorangutan · 2025-10-13T18:38:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-13T20:29:41Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15442

weizhouapache · 2025-10-13T21:02:19Z

@blueorangutan test ol8 vmware-80u3

blueorangutan · 2025-10-13T21:04:03Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-80u3) has been kicked to run smoke tests

blueorangutan · 2025-10-13T21:18:34Z

[SF] Trillian Build Failed (tid-14657)

vishesh92

clgtm

weizhouapache · 2025-10-14T08:54:41Z

@blueorangutan test ol8 vmware-80u3

blueorangutan · 2025-10-14T08:56:03Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-80u3) has been kicked to run smoke tests

weizhouapache · 2025-10-15T09:42:14Z

Merging based on approvals and smoke test results on various hypervisors

blueorangutan · 2025-10-15T14:15:19Z

[SF] Trillian test result (tid-14662)
Environment: vmware-80u3 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 101899 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11823-t14662-vmware-80u3.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_upgrade_kubernetes_cluster	`Failure`	3745.86	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	2223.25	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	3710.09	test_kubernetes_clusters.py
test_list_vms_metrics_admin	`Error`	3618.78	test_metrics_api.py
test_list_vms_metrics_history	`Error`	7.94	test_metrics_api.py
test_list_volumes_metrics_history	`Error`	3625.60	test_metrics_api.py

…he#11823)

systemvm: fix duplicated "en_US.UTF-8 UTF-8" in /etc/locale.gen
144672c

boring-cyborgBot added component:templates systemvm-template-change labels Oct 10, 2025

weizhouapache added this to the 4.20.2 milestone Oct 10, 2025

weizhouapache requested review from DaanHoogland, harikrishna-patnala and yadvr October 13, 2025 06:15

DaanHoogland reviewed Oct 13, 2025
View reviewed changes

harikrishna-patnala approved these changes Oct 13, 2025
View reviewed changes

weizhouapache marked this pull request as ready for review October 13, 2025 17:14

apache deleted a comment from blueorangutan Oct 13, 2025

vishesh92 approved these changes Oct 14, 2025
View reviewed changes

weizhouapache mentioned this pull request Oct 14, 2025
Unable to launch CKS cluster on 4.22 build with vmware 8 #11831
Closed

yadvr approved these changes Oct 14, 2025
View reviewed changes

weizhouapache merged commit b82369c into apache:4.20Oct 15, 2025
25 checks passed

weizhouapache deleted the 4.20-fix-vmware80-locales branch October 15, 2025 09:43

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 17, 2025
systemvm: fix duplicated "en_US.UTF-8 UTF-8" in /etc/locale.gen (apac…
051efd9
…he#11823)

Uh oh!

Conversation

weizhouapache commented Oct 10, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

weizhouapache commented Oct 10, 2025

Uh oh!

blueorangutan commented Oct 10, 2025

Uh oh!

codecovBot commented Oct 10, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Oct 10, 2025

Uh oh!

blueorangutan commented Oct 10, 2025

Uh oh!

blueorangutan commented Oct 11, 2025

Uh oh!

blueorangutan commented Oct 11, 2025

Uh oh!

blueorangutan commented Oct 11, 2025

Uh oh!

blueorangutan commented Oct 11, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Oct 13, 2025

Uh oh!

harikrishna-patnala left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Oct 13, 2025

Uh oh!

blueorangutan commented Oct 13, 2025

Uh oh!

weizhouapache commented Oct 13, 2025

Uh oh!

blueorangutan commented Oct 13, 2025

Uh oh!

blueorangutan commented Oct 13, 2025

Uh oh!

weizhouapache commented Oct 13, 2025

Uh oh!

blueorangutan commented Oct 13, 2025

Uh oh!

blueorangutan commented Oct 13, 2025

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Oct 14, 2025

Uh oh!

blueorangutan commented Oct 14, 2025

Uh oh!

weizhouapache commented Oct 15, 2025

Uh oh!

Uh oh!

blueorangutan commented Oct 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecovBot commented Oct 10, 2025•
edited
Loading