Uh oh!
There was an error while loading. Please reload this page.
CLOUDSTACK-9127 Missing PV-bootloader-args for "SUSE Linux Enterprise… - #1196
Merged
Conversation
remibergsma
commented
Dec 10, 2015
Contributor
LGTM based on these tests: Result: And: Result: Haven't tested the actual feature yet. Seems a nice improvement for people using SUSE. |
Contributor
There was a problem hiding this comment.
Change looks good and simple. Could you please add an unit test to cover the new method?
Cheers,
Wilder
ContributorAuthor
There was a problem hiding this comment.
Added a unit test to cover the newly added method.
Thanks,
Sudharma
wilderrodrigues
commented
Dec 10, 2015
Contributor
Thanks for testing and adding the screenshots, @SudharmaJain! Waiting for you reply on the unit test question I asked. |
remibergsma
commented
Dec 12, 2015
Contributor
Ping @wilderrodrigues |
DaanHoogland
commented
Dec 12, 2015
Contributor
lgtm, doing a test build, now. (not so lgtm @SudharmaJain please see my remark about imports) |
wilderrodrigues
commented
Dec 12, 2015
Contributor
Go for it, @remibergsma! Changes LGTM 👍 @DaanHoogland: should we wait for the outcome of your build? Cheers, |
Contributor
There was a problem hiding this comment.
import * is not accepted per the style guidelines enforced by checkstyle. please replace.
[INFO] Starting audit...
/Users/daan/cloudstack/cloudstack/plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/CitrixHelperTest.java:6: Using the '.*' form of import should be avoided - org.junit.Assert.*.
Audit done.
hence
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 07:29 min
[INFO] Finished at: 2015-12-12T14:18:54+01:00
[INFO] Final Memory: 93M/788M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) on project cloud-plugin-hypervisor-xenserver: Failed during checkstyle execution: There are 1 checkstyle errors. -> [Help 1]
remibergsma
commented
Dec 12, 2015
Contributor
Nice find @DaanHoogland Can you please fix this @SudharmaJain ? Thanks! |
… Server 10 SP2 and SP3" Added Unit test for the new method
SudharmaJain
commented
Dec 14, 2015
ContributorAuthor
Fixed the build. |
DaanHoogland
commented
Dec 14, 2015
Contributor
thanks @SudharmaJain building again |
DaanHoogland
commented
Dec 14, 2015
Contributor
LGTM |
asfgit pushed a commit
that referenced
this pull request
Dec 14, 2015
CLOUDSTACK-9127 Missing PV-bootloader-args for "SUSE Linux Enterprise Server 10 SP2 and SP3"
ISSUE
--------
STOP-START of SUSE Linux VMs fail, as PV-bootloader-args are missing during the start command.
DESCRIPTION
----------------------
Repro steps
1. Upload Suse ISO
2. Create a VM with this ISO, and install it.
3. Detach ISO from the VM.
4. Reboot the VM, :>>>> This will work fine, as the pv-bootloader-args are not missing during reboot.
5.Stop the VM from CCP(VM will get destroyed in Xencenter)
6. Start the same VM from CCP , it will try to start but will fail.
Before Applying the fix
--------------------------------
Before applying the starting the VM failed with following exception
com.cloud.utils.exception.CloudRuntimeException: Unable to start VM(i-2-6-VM) on host(7cfd6388-b763-4c09-b3a3-9679db2904a3) due to Task failed! Task record: uuid: 21a6799f-9523-7c0e-bb86-1de750a38d74
nameLabel: Async.VM.start_on
nameDescription:
allowedOperations: []
currentOperations: {}
created: Wed Dec 09 07:00:29 UTC 2015
finished: Wed Dec 09 07:00:31 UTC 2015
status: failure
residentOn: com.xensource.xenapi.Host@513d238c
progress: 1.0
type: <none/>
result:
errorInfo: [BOOTLOADER_FAILED, OpaqueRef:0b10b6ac-837d-29af-da9d-6ef1e11a064a, Unable to find partition containing kernel
]
otherConfig: {}
subtaskOf: com.xensource.xenapi.Task@aaf13f6f
subtasks: []
After Applying the fix
--------------------------
After applying the fix I am able to start the vm.
* pr/1196:
CLOUDSTACK-9127 Missing PV-bootloader-args for "SUSE Linux Enterprise Server 10 SP2 and SP3"
Signed-off-by: Daan Hoogland <daan@onecht.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… Server 10 SP2 and SP3"
ISSUE
STOP-START of SUSE Linux VMs fail, as PV-bootloader-args are missing during the start command.
DESCRIPTION
Repro steps
5.Stop the VM from CCP(VM will get destroyed in Xencenter)
Before Applying the fix
Before applying the starting the VM failed with following exception
com.cloud.utils.exception.CloudRuntimeException: Unable to start VM(i-2-6-VM) on host(7cfd6388-b763-4c09-b3a3-9679db2904a3) due to Task failed! Task record: uuid: 21a6799f-9523-7c0e-bb86-1de750a38d74
nameLabel: Async.VM.start_on
nameDescription:
allowedOperations: []
currentOperations: {}
created: Wed Dec 09 07:00:29 UTC 2015
finished: Wed Dec 09 07:00:31 UTC 2015
status: failure
residentOn: com.xensource.xenapi.Host@513d238c
progress: 1.0
type:
result:
errorInfo: [BOOTLOADER_FAILED, OpaqueRef:0b10b6ac-837d-29af-da9d-6ef1e11a064a, Unable to find partition containing kernel
]
otherConfig: {}
subtaskOf: com.xensource.xenapi.Task@aaf13f6f
subtasks: []
After Applying the fix
After applying the fix I am able to start the vm.
