Uh oh!
There was an error while loading. Please reload this page.
CLOUDSTACK-9103 : Missing OS Mappings for VMware 6.0 - #1216
Conversation
There was a problem hiding this comment.
For master/4.7.0, we don't need the sql changes in 452-to-460.sql. Please remove this.
LGTM, otherwise.
agneya2001
commented
Dec 11, 2015
LGTM |
DaanHoogland
commented
Dec 11, 2015
@agneya2001 please expand on what LGTY, the titel of the PR, the commit message, your test results? |
agneya2001
commented
Dec 11, 2015
Elaborating on my LGTM: The changes are in right upgrade path. The sql script is error free. It adds guest os support for 6.0 excluding the ones that are deprecated. It also adds rhel7 support for 5.5 that is as per documentation. |
maneesha-p
commented
Dec 14, 2015
@bhaisaab@agneya2001@DaanHoogland 2 LGTMs can it be merged? |
DaanHoogland
commented
Dec 14, 2015
@maneesha-p@remibergsma had a go at it just before the creation of the RC yesterday nigt but he encountered merge conflicts. Can you have e look? merge with |
maneesha-p
commented
Dec 14, 2015
@DaanHoogland it was due to a latest change in the db file.Pushed again.Thanks. |
DaanHoogland
commented
Dec 14, 2015
@agneya2001 can you still lgtm this? |
DaanHoogland
commented
Dec 14, 2015
CLOUDSTACK-9103 : Missing OS Mappings for VMware 6.0Added suitable db entries in tables hypervisor_capabilities and guest_os_hypervisor to support VMware 6.0 by copying from 5.5 and excluding few depricated guest os.And also added entries for guest os RHEL 7 for vmware 5.5 and 6.0. * pr/1216: CLOUDSTACK-9103 : Missing OS Mappings for VMware 6.0 Signed-off-by: Daan Hoogland <daan@onecht.net>

Added suitable db entries in tables hypervisor_capabilities and guest_os_hypervisor to support VMware 6.0 by copying from 5.5 and excluding few depricated guest os.And also added entries for guest os RHEL 7 for vmware 5.5 and 6.0.